<p></p>
<p><b>@tomhughes</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/3810#discussion_r1027084167">config/environments/development.rb</a>:</p>
<pre style='color:#555'>> @@ -33,6 +34,8 @@
     config.cache_store = :null_store
   end
 
+  config.logger = ActiveSupport::TaggedLogging.new(ActiveSupport::Logger.new($stdout))
</pre>
<p dir="auto">Your PR does not explain why you are making this change, which affects all users not just docker users.</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/3810#discussion_r1027084193">config/example.database.yml</a>:</p>
<pre style='color:#555'>> @@ -8,6 +8,7 @@ development:
 #  password: openstreetmap
 #  host: localhost
   encoding: utf8
+  pool: <%= ENV["DB_POOL"] || ENV['RAILS_MAX_THREADS'] || 5 %>
</pre>
<p dir="auto">Your PR does not explain why you are making this change, which affects all users not just docker users.</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/3810#discussion_r1027084244">config/environments/development.rb</a>:</p>
<pre style='color:#555'>> @@ -22,8 +22,9 @@
   if Rails.root.join("tmp/caching-dev.txt").exist?
     config.action_controller.perform_caching = true
     config.action_controller.enable_fragment_cache_logging = true
+    config.action_controller.page_cache_directory = Rails.public_path
</pre>
<p dir="auto">Your PR does not explain why you are making this change, which affects all users not just docker users.</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/3810#discussion_r1027084353">config/environments/development.rb</a>:</p>
<pre style='color:#555'>>  
-    config.cache_store = :memory_store
+    config.cache_store = :file_store, Rails.root.join("tmp/cache")
</pre>
<p dir="auto">Why is a file cache better than a memory cache? You say it gives better performance but normally memory is faster than than something that is disk backed? Bearing in mind that this affects all users is the performance benefit in fact only when running under docker?</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/3810#pullrequestreview-1187067432">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLJU7L2ZRUBN6PUXAADWJDCBZANCNFSM6AAAAAASFHW5EU">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLKRTLFN4KQECG3LIQ3WJDCBZA5CNFSM6AAAAAASFHW5EWWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTSGYE3CQ.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/3810/review/1187067432</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/3810#pullrequestreview-1187067432",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/3810#pullrequestreview-1187067432",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>