<p dir="auto">"Pagination working properly without javascript" from <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="23996607" data-permission-text="Title is private" data-url="https://github.com/openstreetmap/openstreetmap-website/issues/647" data-hovercard-type="issue" data-hovercard-url="/openstreetmap/openstreetmap-website/issues/647/hovercard?comment_id=1298624196&comment_type=issue_comment" href="https://github.com/openstreetmap/openstreetmap-website/issues/647#issuecomment-1298624196">#647 (comment)</a>.</p>
<p dir="auto">The link actually exists even without this PR. You can open any changeset list page, middle-click the "Load more" button and you'll get the next page but it won't have the correct layout.</p>
<p dir="auto">This PR makes the link work as a proper webpage. Also it changes the link from <code class="notranslate">.../history?max_id=(id)</code> to <code class="notranslate">.../history/(id)</code>. This makes it possible to construct permalinks to some point in time of someone's edit history.</p>
<p dir="auto">The plan is later to update the id in the url when the sidebar is scrolled, similar to how <a href="https://community.openstreetmap.org/" rel="nofollow">the new forum</a> updates its urls with comment numbers. This would roughly do what was requested in <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="62665400" data-permission-text="Title is private" data-url="https://github.com/openstreetmap/openstreetmap-website/issues/933" data-hovercard-type="issue" data-hovercard-url="/openstreetmap/openstreetmap-website/issues/933/hovercard" href="https://github.com/openstreetmap/openstreetmap-website/issues/933">#933</a>. Also it would do <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="23996607" data-permission-text="Title is private" data-url="https://github.com/openstreetmap/openstreetmap-website/issues/647" data-hovercard-type="issue" data-hovercard-url="/openstreetmap/openstreetmap-website/issues/647/hovercard" href="https://github.com/openstreetmap/openstreetmap-website/issues/647">#647</a> but without caching.</p>
<hr>
<h4>You can view, comment on, or merge this pull request online at:</h4>
<p> <a href='https://github.com/openstreetmap/openstreetmap-website/pull/3829'>https://github.com/openstreetmap/openstreetmap-website/pull/3829</a></p>
<h4>Commit Summary</h4>
<ul>
<li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/3829/commits/f360298c03468d998f5e364c9e1309d74dfb5ac7" class="commit-link">f360298</a> Add ajax parameters to 'Load more' links with javascript</li>
<li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/3829/commits/af182f4007b932d3d930d2de5545285835842a20" class="commit-link">af182f4</a> Rename changeset loader functions</li>
<li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/3829/commits/227147bfdde8815f6349efe0693d4fb5ef91a1ae" class="commit-link">227147b</a> Add tests for user's history max_id parameter support</li>
<li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/3829/commits/d0d76164ac410b98bc09188a86971ae1d7da0295" class="commit-link">d0d7616</a> Get max_id from static page path, use it to load first changesets</li>
<li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/3829/commits/e8dfb2ff36fc098f33b2422b98ca88b657da3156" class="commit-link">e8dfb2f</a> Make max_id part of url path</li>
<li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/3829/commits/e9d9fff4b0fe59105d31f0048429b1d76ad1f075" class="commit-link">e9d9fff</a> Update place history url test to be aware of max_id</li>
<li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/3829/commits/74742a29d822cc1218d807a56f38ce7d420b6ad1" class="commit-link">74742a2</a> Remove max_id from url when viewing place history and map is moved</li>
</ul>
<h4 style="display: inline-block">File Changes </h4> <p style="display: inline-block">(<a href="https://github.com/openstreetmap/openstreetmap-website/pull/3829/files">6 files</a>)</p>
<ul>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/3829/files#diff-cdc070ced1c4000efd1e28357fd26b2fd617d7fccfeae0324222231db75dd6ee">app/assets/javascripts/index.js</a>
(8)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/3829/files#diff-25cab16df4a58e0c8e53d0a0e70d9bbf28ef3beb9e6bf1208234fdeed7515392">app/assets/javascripts/index/history.js</a>
(55)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/3829/files#diff-db453eec0cc09b6371bff627c927278e1d99e90a16ff58cd7deafb4aeb457f49">app/views/changesets/index.html.erb</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/3829/files#diff-959bc9abc46a55332bb64d5155a79323afa75a50ec1a2137ddd22d926f62c6c5">config/routes.rb</a>
(8)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/3829/files#diff-6cdb8b8fa44e422834c4815943a8e4933d6d09e4687f338d007daeff1a90daa9">test/controllers/changesets_controller_test.rb</a>
(38)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/3829/files#diff-ca76ddfd495be1ab96863518b57d1e0b49d06c99429adb2bbd6001692d12073b">test/system/history_test.rb</a>
(45)
</li>
</ul>
<h4>Patch Links:</h4>
<ul>
<li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/3829.patch'>https://github.com/openstreetmap/openstreetmap-website/pull/3829.patch</a></li>
<li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/3829.diff'>https://github.com/openstreetmap/openstreetmap-website/pull/3829.diff</a></li>
</ul>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/3829">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLMQSVY45ER7IC5VUYLWMCYQHANCNFSM6AAAAAASW73KEM">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLJSDLU6EU4UYRCHWTDWMCYQHA5CNFSM6AAAAAASW73KEOWGG33NNVSW45C7OR4XAZNFJFZXG5LFVJRW63LNMVXHIX3JMTHFQWNIW4.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/3829</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/3829",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/3829",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>