<p></p>
<p><b>@tomhughes</b> requested changes on this pull request.</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/3829#discussion_r1044676026">app/assets/javascripts/index/history.js</a>:</p>
<pre style='color:#555'>> @@ -173,7 +178,14 @@ OSM.History = function (map) {
 
     map.on("zoomend", updateBounds);
 
-    loadFirstChangesets();
+    var maxId;
+    var paramsIndex = path.indexOf("?");
+    if (paramsIndex >= 0) {
+      var params = Qs.parse(path.substring(paramsIndex + 1));
+      maxId = params.max_id;
+    }
+
+    loadFirstChangesets(maxId);
</pre>
<p dir="auto">I don't understand the point of this, indeed of any of this commit, when you remove it all again in the next commit?</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/3829#discussion_r1044677882">app/views/changesets/index.html.erb</a>:</p>
<pre style='color:#555'>> @@ -4,7 +4,7 @@
   </ol>
 <% if @changesets.size == 20 -%>
   <div class="changeset_more mt-3 text-center">
-    <%= link_to t(".load_more"), url_for(@params.merge(:max_id => @changesets.last.id - 1)), :class => "btn btn-primary" %>
+    <%= link_to t(".load_more"), "#{url_for}/#{@changesets.last.id - 1}", :class => "btn btn-primary" %>
</pre>
<p dir="auto">That way of constructing the URL is not a good idea - doesn't <code class="notranslate">url_for(:max_id => @changesets.last.id - 1)</code> work? If not then there will something which does and which doesn't rely on manually gluing the component together like that.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/3829#pullrequestreview-1211989461">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLJM5EJUPQWFVVOCIITWMNV4DANCNFSM6AAAAAASW73KEM">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLOYXJKSPV35EQEJRI3WMNV4DA5CNFSM6AAAAAASW73KEOWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTSIHV65K.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/3829/review/1211989461</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/3829#pullrequestreview-1211989461",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/3829#pullrequestreview-1211989461",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>