<p dir="auto">As a historical legacy, we currently return search results from Geonames and geocoder.ca.</p>
<p dir="auto">We did this in the early days of OSM as a convenience to help people navigate round the map - i.e. if Frogsbury hadn't been mapped yet, it was useful to be able to navigate to Frogsbury and start contributing there. Now that OSM's coverage is so much greater, there's no need for this any more. It's counter-intuitive to return non-OSM data when searching osm.org, and IMX Geonames usually returns "No results found" in any case.</p>
<p dir="auto">This PR simply removes the support for Geonames and geocoder.ca. The only remaining geocoder engines are Nominatim (forward/reverse) and the simple latlon reader.</p>
<p dir="auto">Ultimately this is a very small step towards replacing GeocoderController with client-side parsing of Nominatim responses, which would make them easier to use in other contexts (e.g. the placename search for routing), as per <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="6641373" data-permission-text="Title is private" data-url="https://github.com/openstreetmap/openstreetmap-website/issues/80" data-hovercard-type="issue" data-hovercard-url="/openstreetmap/openstreetmap-website/issues/80/hovercard" href="https://github.com/openstreetmap/openstreetmap-website/issues/80">#80</a>. <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="326387849" data-permission-text="Title is private" data-url="https://github.com/openstreetmap/openstreetmap-website/issues/1881" data-hovercard-type="issue" data-hovercard-url="/openstreetmap/openstreetmap-website/issues/1881/hovercard" href="https://github.com/openstreetmap/openstreetmap-website/issues/1881">#1881</a> also refers.</p>
<hr>
<h4>You can view, comment on, or merge this pull request online at:</h4>
<p> <a href='https://github.com/openstreetmap/openstreetmap-website/pull/3886'>https://github.com/openstreetmap/openstreetmap-website/pull/3886</a></p>
<h4>Commit Summary</h4>
<ul>
<li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/3886/commits/b7887b049fa1aae17f8b7020fe43542fffde1260" class="commit-link">b7887b0</a> Remove Geonames and geocoder.ca</li>
</ul>
<h4 style="display: inline-block">File Changes </h4> <p style="display: inline-block">(<a href="https://github.com/openstreetmap/openstreetmap-website/pull/3886/files">10 files</a>)</p>
<ul>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/3886/files#diff-debf59904131dc89a88ab44cbb1d6deaaa5a7d70c0507f674080df62f7c8e41f">app/abilities/ability.rb</a>
(3)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/3886/files#diff-bf845b955a0aeb626484399330d9c39183e734c9a56a3900e71fa48b0da47f81">app/controllers/geocoder_controller.rb</a>
(98)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/3886/files#diff-44438ce218f5287c58d0017f965d888715635d94280669896f75841fbd7b4cd7">config/locales/en.yml</a>
(3)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/3886/files#diff-959bc9abc46a55332bb64d5155a79323afa75a50ec1a2137ddd22d926f62c6c5">config/routes.rb</a>
(3)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/3886/files#diff-e769bbb8c1ba3711c5403b424ed9c218ffafba7f1890ee394717196f28ff4540">config/settings.yml</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/3886/files#diff-35b4e12cc4861df996689cfdc4006b266c22d40a0ecefd2ab6c74d817e20bf8b">config/settings/test.yml</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/3886/files#diff-66914b664fcadd6ba28bd16a44eb853ca3fd4e1f9ea1e4be390f12aeea2a0697">test/abilities/abilities_test.rb</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/3886/files#diff-1453e8dc6e5e9eca02ad81af68bc85fdaab1cd0d9a02e7927a1a46d06bc204ca">test/controllers/geocoder_controller_test.rb</a>
(83)
</li>
<li>
<strong>D</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/3886/files#diff-9608920e00e91619fd67cd063005ef26b730aa311630a40289f21201a6de3ae0">test/http/geocoder_ca.yml</a>
(54)
</li>
<li>
<strong>D</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/3886/files#diff-dabf1703f99d73e50d914c1dd46eb9d04d2883ed1dd130a7e1536a0326a3492e">test/http/geonames.yml</a>
(228)
</li>
</ul>
<h4>Patch Links:</h4>
<ul>
<li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/3886.patch'>https://github.com/openstreetmap/openstreetmap-website/pull/3886.patch</a></li>
<li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/3886.diff'>https://github.com/openstreetmap/openstreetmap-website/pull/3886.diff</a></li>
</ul>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/3886">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLK37V3PUC2TYPV3CDLWRR76JANCNFSM6AAAAAATV47ZBA">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLJITYJ5DTFZD6R6NI3WRR76JA5CNFSM6AAAAAATV47ZBCWGG33NNVSW45C7OR4XAZNFJFZXG5LFVJRW63LNMVXHIX3JMTHFV6TFZU.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/3886</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/3886",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/3886",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>