<p></p>
<blockquote>
<p dir="auto">It's not really our <code class="notranslate">bin/yarn</code> script... I'm pretty sure it came from rails and I just hacked it to add the switch and now rails has stopped using it.</p>
</blockquote>
<p dir="auto">I meant that it's ours now <g-emoji class="g-emoji" alias="smile" fallback-src="https://github.githubassets.com/images/icons/emoji/unicode/1f604.png">😄</g-emoji> Yes, it came from upstream rails, but they've stopped creating it for new applications. In different circumstances we would be deleting it as no longer required.</p>
<blockquote>
<p dir="auto">I'm kind of reluctant to switch away from upstream's documented way of doing things,</p>
</blockquote>
<p dir="auto">So am I, but I think the alternatives are worse.</p>
<ul dir="auto">
<li>If we do <code class="notranslate">bundle exec rails yarn:install</code> then we need to require non-Ubuntu packaged yarn, and we need to require everyone installs Nodejs 16+ (for no good reason).</li>
<li>If we do <code class="notranslate">yarn install --ignore-engines</code>, then we still need to explain that it's <code class="notranslate">yarnpkg install --ignore-engines</code> on Ubuntu, which is additional complexity.</li>
<li>Alternatively we do <code class="notranslate">bundle exec bin/yarn install</code> as per this PR.</li>
</ul>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/3890#issuecomment-1378897411">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLIWOMEKHENCBPITGTDWR3D3TANCNFSM6AAAAAATYC45WA">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLLJI5POR2XHZR7ULNDWR3D3TA5CNFSM6AAAAAATYC45WCWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTSSGBHAG.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/3890/c1378897411</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/3890#issuecomment-1378897411",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/3890#issuecomment-1378897411",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>