<p></p>
<p><b>@gravitystorm</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/3911#discussion_r1093527545">config/locales/en.yml</a>:</p>
<pre style='color:#555'>> @@ -2915,22 +2928,6 @@ en:
         unsubscribe: "Unsubscribe"
         hide_comment: "hide"
         unhide_comment: "unhide"
-    notes:
-      new:
-        intro: "Spotted a mistake or something missing? Let other mappers know so we can fix it. Move the marker to the correct position and type a note to explain the problem."
-        advice: "Your note is public and may be used to update the map, so don't enter personal information, or information from copyrighted maps or directory listings."
-        add: Add Note
-      show:
-        anonymous_warning: This note includes comments from anonymous users which should be independently verified.
-        hide: Hide
-        resolve: Resolve
-        reactivate: Reactivate
-        comment_and_resolve: Comment & Resolve
</pre>
<p dir="auto">Great catch. I've added a system test that would have caught this.</p>
<p dir="auto">I had a look to see what alternative approaches there are, to avoid having javascript determine the translated text, and to allow us to keep all content-related stuff in the erb view. I can see that Github uses data attributes for its own issue button ("Close issue" and "Close with Comment"), and uses javascript only to swap between them (rather than fetching one of the strings from elsewhere). So I've adopted the same pattern here.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/3911#discussion_r1093527545">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLONEJP5E5UA6XVLD6DWVKMGJANCNFSM6AAAAAAUHNECOU">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLLXCYPUF3WCT35Y4N3WVKMGJA5CNFSM6AAAAAAUHNECOWWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTSMISJIO.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/3911/review/1279562375</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/3911#discussion_r1093527545",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/3911#discussion_r1093527545",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>