<p></p>
<p dir="auto"><a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/angoca/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/angoca">@angoca</a> thank you for your pull request.</p>
<p dir="auto">I agree with <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/tomhughes/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/tomhughes">@tomhughes</a> on this, and I have several other objections to this approach, as <a href="https://github.com/openstreetmap/openstreetmap-website/issues/3932#issuecomment-1440222022" data-hovercard-type="issue" data-hovercard-url="/openstreetmap/openstreetmap-website/issues/3932/hovercard">I've commented in the related issue</a>. So I'm going to decline this pull request.</p>
<p dir="auto">I'm going to review this PR anyway, with the aim of helping you with making future PRs. So here are my notes:</p>
<ul dir="auto">
<li>I'm not sure that <code class="notranslate">#website</code> is particularly descriptive, especially if other hashtags are in use for other reasons than just marking what creating the notes (e.g. if there are hashtags for topics or challenges). It doesn't clearly indicate which website created it, for example, and other websites might start using <code class="notranslate">#website</code> too. Instead I would consider using the "generator" from our configuration, or perhaps something from the translations (<code class="notranslate">layouts.project_name</code>?) that is a) more descriptive b) more precise and c) likely to be configured differently for other installations of the software.</li>
<li>If we are formally adding a structure to what was previously free-form text, we would need to indicate some kind of parsing rules for applications that want to consume it. For example, what characters are valid in a hashtag, what characters delineate one, etc.</li>
<li>From <a href="https://github.com/openstreetmap/openstreetmap-website/blob/master/CONTRIBUTING.md#pull-requests">CONTRIBUTING.md#pull-requests</a> - please don't include fixup commits. One of the commits in this PR is entirely replacing the other, so they should be combined together (using e.g. <code class="notranslate">git rebase -i</code>) into a single clean commit.</li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/3938#issuecomment-1440247404">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLPZ2Q4FIRAKTXA3QPDWYYVMTANCNFSM6AAAAAAVEMHIQI">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLMBGEQYBGALOY45FMTWYYVMTA5CNFSM6AAAAAAVEMHIQKWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTSV3BXGY.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/3938/c1440247404</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/3938#issuecomment-1440247404",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/3938#issuecomment-1440247404",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>