<p></p>
<p><b>@gravitystorm</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/3936#discussion_r1114149714">app/views/accounts/_go_public.html.erb</a>:</p>
<pre style='color:#555'>> @@ -0,0 +1,14 @@
+<hr class="mb-3" />
+<a name="public"></a>
+<h2><%= t ".heading" %></h2>
+<p>
+  <%= t ".currently_not_public" %>
+  <strong><%= t ".only_public_can_edit" %></strong>
+  <%= t ".find_out_why_html", :link => link_to(t(".find_out_why"),
+                                               t(".find_out_why_url")) %>
</pre>
<p dir="auto">I think it's worth the tradeoff in any slight translation difficulty to be able to avoid translators having to get the html right.</p>
<p dir="auto">The approach here, of having the link text in a separate string interpolated into the whole sentence, is exactly what we need to use when the urls are being generated - e.g. we can't put raw html with path helpers like <code class="notranslate">foo bar <a href="new_diary_entry_path(user)>link text</a></code> into a translation. So there's also an argument that for consistency, all sentences with links should follow the same interpolation pattern, even if the link could be inlined into the translation.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/3936#discussion_r1114149714">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLK6O7PSBMRFDYJ5NI3WYXUUBANCNFSM6AAAAAAVECLM6U">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLN3GWNL5YMRRXMD4WTWYXUUBA5CNFSM6AAAAAAVECLM6WWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTSOAVV72.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/3936/review/1308978173</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/3936#discussion_r1114149714",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/3936#discussion_r1114149714",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>