<p></p>
<p dir="auto">Beyond that, I would like to find a better approach where the views pass these overrides into the opengraph tags, rather than using instance variables in the controllers. I believe the view is the right place for declaring these tags, since choosing "how something is shown" is the concern of the view, rather than the controller (which is more about fetching the data). So I would expect all the choices about titles, length of text etc to be written in app/views/diary_entries/show.html.erb and somehow make their way to the right place in the layout. For example, we use <code class="notranslate">content_for</code> for passing html to the <code class="notranslate"><head></code> already, but it's not quite the same here since we want to pass overrides to the opengraph defaults.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/3942#issuecomment-1445143301">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLIWY6QBS5BWAXOKHODWZIQ6FANCNFSM6AAAAAAVH4K7HM">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLKEQXDHKXJ2MG5UY6DWZIQ6FA5CNFSM6AAAAAAVH4K7HOWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTSWEMRQK.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/3942/c1445143301</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/3942#issuecomment-1445143301",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/3942#issuecomment-1445143301",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>