<p dir="auto">This PR continues the work of removing raw html from our translations.</p>
<p dir="auto">I noticed as part of this a couple of issues with our timestamps (not withstanding <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="23830914" data-permission-text="Title is private" data-url="https://github.com/openstreetmap/openstreetmap-website/issues/631" data-hovercard-type="issue" data-hovercard-url="/openstreetmap/openstreetmap-website/issues/631/hovercard" href="https://github.com/openstreetmap/openstreetmap-website/issues/631">#631</a>):</p>
<ul dir="auto">
<li>We are using <code class="notranslate">abbr</code> tags, but these aren't abbreviations. This could confuse screenreaders etc.</li>
<li>We are inconsistent with how we display the timestamps. Sometimes we use the <code class="notranslate">friendly_date_ago</code> helper, which wraps the timestamp in a <code class="notranslate">span</code> with a title, and that is then wrapped again in an <code class="notranslate">abbr</code> with another, slightly different, title. Sometimes we just have one level of wrapping, in the <code class="notranslate">abbr</code> alone.</li>
<li>This inconsistency means that the titles shown by browsers are also inconsistent - sometimes they are rounded to the nearest minute (friendly dates) and other times are to the second with <code class="notranslate">+00:00</code> timezones shown.</li>
</ul>
<p dir="auto">In this PR I made no attempt to address these issues, instead keeping everything exactly as it was previously. But I thought I should mention it here anyway, since wrapping <code class="notranslate">friendly_date_ago</code> looks a bit strange.</p>
<hr>
<h4>You can view, comment on, or merge this pull request online at:</h4>
<p> <a href='https://github.com/openstreetmap/openstreetmap-website/pull/3986'>https://github.com/openstreetmap/openstreetmap-website/pull/3986</a></p>
<h4>Commit Summary</h4>
<ul>
<li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/3986/commits/de1b92819ae08670a8f18513852f2263bd5a8526" class="commit-link">de1b928</a> Avoid using raw html in translations on the about page</li>
<li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/3986/commits/ae37c836c7715b9ff91634f099930a5c0089ea9b" class="commit-link">ae37c83</a> Avoid using raw html in translations for the issues index</li>
<li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/3986/commits/a72817bc08a9d8d10b48fe2a534980722f3db53b" class="commit-link">a72817b</a> Avoid raw html in translations for changeset comments</li>
<li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/3986/commits/3a5aba00c113474f505f4f3a5fd61a0e17720cd0" class="commit-link">3a5aba0</a> Rework browse pages to avoid raw html in translations</li>
</ul>
<h4 style="display: inline-block">File Changes </h4> <p style="display: inline-block">(<a href="https://github.com/openstreetmap/openstreetmap-website/pull/3986/files">7 files</a>)</p>
<ul>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/3986/files#diff-bc4d52553ca058396b0e614d583f5a157ea848b90d792eb1c872f4233b0fe5db">app/helpers/changesets_helper.rb</a>
(10)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/3986/files#diff-9dea4ffe487a631e3df942ebeec041974e762348f767704f27c52bc97e89052f">app/views/browse/_common_details.html.erb</a>
(8)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/3986/files#diff-fba7159a4abd78f8b24f765a0c58ebe47a24be99e185c373175f20f612a5d781">app/views/browse/changeset.html.erb</a>
(12)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/3986/files#diff-ed96df420873aaa1d006204ba97c74a9ffcbe5c21c25de224b6b4c95edb8cd7a">app/views/issues/index.html.erb</a>
(10)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/3986/files#diff-20b1b4068a14bbb692bf60b143f2cd17d495893dbd397e41eadeb732056341d7">app/views/site/about.html.erb</a>
(41)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/3986/files#diff-44438ce218f5287c58d0017f965d888715635d94280669896f75841fbd7b4cd7">config/locales/en.yml</a>
(76)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/3986/files#diff-7e264c813f970de382cf9794190fe845a032231954a5cf6f42d55ac2e82c474b">test/helpers/changesets_helper_test.rb</a>
(4)
</li>
</ul>
<h4>Patch Links:</h4>
<ul>
<li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/3986.patch'>https://github.com/openstreetmap/openstreetmap-website/pull/3986.patch</a></li>
<li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/3986.diff'>https://github.com/openstreetmap/openstreetmap-website/pull/3986.diff</a></li>
</ul>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/3986">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLMCEBUDATCKLFC242DW5QOJZANCNFSM6AAAAAAWE7CFQE">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLMBNPXKJNOCRAAASATW5QOJZA5CNFSM6AAAAAAWE7CFQGWGG33NNVSW45C7OR4XAZNFJFZXG5LFVJRW63LNMVXHIX3JMTHGDFP4CU.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/3986</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/3986",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/3986",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>