<p></p>
<p dir="auto"><a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/Prathm-s/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/Prathm-s">@Prathm-s</a> thank you for your first pull request.</p>
<p dir="auto">I think the share sidebar ends up quite cramped, but perhaps usable, just about:<br>
<a target="_blank" rel="noopener noreferrer" href="https://user-images.githubusercontent.com/360803/245751185-f76e5d2d-0d26-4099-b222-bde75e44e50e.png"><img src="https://user-images.githubusercontent.com/360803/245751185-f76e5d2d-0d26-4099-b222-bde75e44e50e.png" alt="3988d1" style="max-width: 100%;"></a></p>
<p dir="auto">It also changes the other sidebars, like the layers menu:<br>
<a target="_blank" rel="noopener noreferrer" href="https://user-images.githubusercontent.com/360803/245751175-bea7c017-4629-49d6-b709-4a7dcbc67b4f.png"><img src="https://user-images.githubusercontent.com/360803/245751175-bea7c017-4629-49d6-b709-4a7dcbc67b4f.png" alt="3988c1" style="max-width: 100%;"></a></p>
<p dir="auto">But it breaks the query tool and the new note panels.<br>
<a target="_blank" rel="noopener noreferrer" href="https://user-images.githubusercontent.com/360803/245750605-739cf2a3-ad5c-4f75-81eb-f0440524a14c.png"><img src="https://user-images.githubusercontent.com/360803/245750605-739cf2a3-ad5c-4f75-81eb-f0440524a14c.png" alt="3988a1" style="max-width: 100%;"></a></p>
<p dir="auto"><a target="_blank" rel="noopener noreferrer" href="https://user-images.githubusercontent.com/360803/245751170-5553bc45-2d42-47b8-91ea-2ad084da3abc.png"><img src="https://user-images.githubusercontent.com/360803/245751170-5553bc45-2d42-47b8-91ea-2ad084da3abc.png" alt="3988b1" style="max-width: 100%;"></a></p>
<p dir="auto">Compare the above with the way that the note panel works currently:<br>
<a target="_blank" rel="noopener noreferrer" href="https://user-images.githubusercontent.com/360803/245751325-48f81407-8f9d-4ed1-926b-62b970ad2542.png"><img src="https://user-images.githubusercontent.com/360803/245751325-48f81407-8f9d-4ed1-926b-62b970ad2542.png" alt="3988de" style="max-width: 100%;"></a></p>
<p dir="auto">So I'm going to decline this PR, since it breaks other functionality on the page.</p>
<p dir="auto">You are welcome to make another PR, in which case please consider:</p>
<ul dir="auto">
<li>Please check that your changes don't break any of the other sidebar panels.</li>
<li>Is it better to use the same over/below layout as the Query Tool and New Note panels? Or is side-by-side better?</li>
<li>Please make a full commit message. We have some guidance in our <a href="https://github.com/openstreetmap/openstreetmap-website/blob/master/CONTRIBUTING.md#committing">CONTRIBUTING.md</a> file.</li>
</ul>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/3992#issuecomment-1590877580">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLII6PAAF76PA5OI2P3XLGDIDANCNFSM6AAAAAAWOQKKOY">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLKTYSJYBUHP2XLHM2TXLGDIDA5CNFSM6AAAAAAWOQKKO2WGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTS62LOYY.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/3992/c1590877580</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/3992#issuecomment-1590877580",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/3992#issuecomment-1590877580",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>