<p></p>
<p dir="auto">I've pushed a new version that I think addresses all your review comments.</p>
<p dir="auto">I did look at the possibility of using a gem but I'm not convinced there's anything that's useful for various reasons.</p>
<p dir="auto">In many ways <a href="https://github.com/Uysim/pagy-cursor">pagy_cursor</a> looks excellent, especially since it's an extension to <a href="https://github.com/ddnexus/pagy">pagy</a> which provides nice view helpers and would be good to replace our existing paging code for places where we do real paging. The problem is that it doesn't really integrate with pagy in any meaningful way and you can't use the pagy navigation helpers as <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="772871609" data-permission-text="Title is private" data-url="https://github.com/Uysim/pagy-cursor/issues/21" data-hovercard-type="issue" data-hovercard-url="/Uysim/pagy-cursor/issues/21/hovercard" href="https://github.com/Uysim/pagy-cursor/issues/21">Uysim/pagy-cursor#21</a> makes clear. It's not entirely their fault as pagy would need changes to allow it to support cursor based paging but there doesn't seem to be any effort to properly integrate them.</p>
<p dir="auto">As to <a href="https://github.com/xing/rails_cursor_pagination">rails_cursor_pagination</a> there is the issue of the rather ugly cursors but we could live with that - you could even argue it's an advantage. There's a killer bug at the moment though (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="1760585845" data-permission-text="Title is private" data-url="https://github.com/xing/rails_cursor_pagination/issues/132" data-hovercard-type="issue" data-hovercard-url="/xing/rails_cursor_pagination/issues/132/hovercard" href="https://github.com/xing/rails_cursor_pagination/issues/132">xing/rails_cursor_pagination#132</a>) in that even if you disable totals it still does the query when working our whether next/previous links are needed!</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4089#issuecomment-1646928233">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLITRJWFE5M6QR6F77LXRVWF3ANCNFSM6AAAAAA2H4NI4Q">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLKZRHGBSYVIEAEBBITXRVWF3A5CNFSM6AAAAAA2H4NI4SWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTTCFIQWS.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/4089/c1646928233</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/4089#issuecomment-1646928233",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/4089#issuecomment-1646928233",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>