<p></p>
<blockquote>
<p dir="auto">When it comes to UX, using red for notification badges is a standard approach in popular design systems such as Android, iOS, and <a href="https://m3.material.io/components/badges/overview" rel="nofollow">Material.io</a></p>
</blockquote>
<p dir="auto">Sure, I understand that other design systems use red for notifications, but that doesn't mean that we have to. There's a balance to be struck between making the badge useful, without going down the "attention economy" UX (anti-)patterns found elsewhere. And as <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/pnorman/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/pnorman">@pnorman</a> points out, there's other examples of using a distinct-but-not-red notification colour too.</p>
<p dir="auto">But in particular, the code in this PR is using <code class="notranslate">bg-danger</code>. It's a deliberate approach to use meaningful (i.e. not colour) names in our styles. This is particularly important when considering themes e.g. dark themes. So <code class="notranslate">danger</code> is an incorrect way to describe notification badges, even if they both happen to be red.</p>
<blockquote>
<p dir="auto"><a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/gravitystorm/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/gravitystorm">@gravitystorm</a> suggested using <code class="notranslate">bg-info</code> which is more cyan than blue.</p>
</blockquote>
<p dir="auto">If the bg-info colour doesn't really work for our colour scheme, then I'm happy to have suggestions for changing it. We haven't fully resolved our custom colours and the bootstrap defaults, so I know some combinations jar with each other. That might be better discussed separately though.</p>
<blockquote>
<p dir="auto"><code class="notranslate">bg-primary</code> would work better since it's actually blue and should stand out more. I will add a screenshot with that variant tommorow.</p>
</blockquote>
<p dir="auto">Happy to see more suggestions. I still think that this is a "info" kind of thing rather than "primary", and if we use "info" and it looks wrong we should consider why that might be.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4070#issuecomment-1651861551">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLKCDR4DKXRQY7WJEBTXSEOYFANCNFSM6AAAAAAZMBHGJM">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLM2C5FBMB5IINFE26DXSEOYFA5CNFSM6AAAAAAZMBHGJOWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTTCOVUC6.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/4070/c1651861551</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/4070#issuecomment-1651861551",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/4070#issuecomment-1651861551",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>