<p></p>
<blockquote>
<p dir="auto">The API block did what? It didn't block trace uploads did it?</p>
</blockquote>
<p dir="auto">Presumably it would. An API block applies to all API methods that call the <a href="https://github.com/openstreetmap/openstreetmap-website/blob/6b633e9d4a49df1f9308ef392203437cb7742558/app/controllers/api_controller.rb#L127"><code class="notranslate">setup_user_auth</code></a> method (or that call it indirectly, e.g. via <a href="https://github.com/openstreetmap/openstreetmap-website/blob/6b633e9d4a49df1f9308ef392203437cb7742558/app/controllers/api_controller.rb#L48-L50"><code class="notranslate">authorize</code></a>)</p>
<p dir="auto">So a user_block will block API access to nodes/ways/relations/changesets and also traces, notes, changeset comments, user preferences, permissions APIs. There's a few other API methods that are not blocked (e.g. map, capabilities, versions, users)</p>
<p dir="auto">I can see the logic in expanding this to cover any API methods that are duplicated in html versions. I view a "User Block" as something to stop a user from doing bad stuff, so if we added e.g. inline tag editing through the website, I would expect it to be blocked too, regardless of implementation details.</p>
<p dir="auto">I suspect we might need to expand UserBlocks themselves at some point, e.g. to have a list of checkboxes for different features, e.g. so that a user can be blocked from uploading traces while still being able to respond to changeset comments, but that's out of scope for now.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4129#issuecomment-1680571181">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLMAUNIUAGHPOLE5QJTXVTAUFANCNFSM6AAAAAA3ACSHSI">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLM3BL34Z5MTBE2XIW3XVTAUFA5CNFSM6AAAAAA3ACSHSKWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTTEFN5S2.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/4129/c1680571181</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/4129#issuecomment-1680571181",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/4129#issuecomment-1680571181",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>