<p dir="auto">For things that have username in their path like <code class="notranslate">https://www.openstreetmap.org/user/<username>/diary</code>. Later also for things with user id in their path.</p>
<p dir="auto">The goal is to make <code class="notranslate">ApplicationController</code> smaller. Code dealing with resolving user names/ids will go into the base class. Adding anything to <code class="notranslate">ApplicationController</code> will cause Rubocop to complain.</p>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/openstreetmap/openstreetmap-website/pull/4197'>https://github.com/openstreetmap/openstreetmap-website/pull/4197</a></p>

<h4>Commit Summary</h4>
<ul>
  <li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/4197/commits/b3507250ba367507851ab6253adf35dd4ddc1a94" class="commit-link">b350725</a>  Create base controller class for user resources</li>
  <li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/4197/commits/1dda90749f318ea1a07ec206d6e49fb5498315c1" class="commit-link">1dda907</a>  Make notes controller inherit from user resources controller</li>
  <li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/4197/commits/f5759a3776ae9ea00b2b3a2dbd4139abb736e693" class="commit-link">f5759a3</a>  Lookup user before action in user's notes list</li>
</ul>

<h4 style="display: inline-block">File Changes </h4> <p style="display: inline-block">(<a href="https://github.com/openstreetmap/openstreetmap-website/pull/4197/files">12 files</a>)</p>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4197/files#diff-766c34fd6533171eaf54300c153f89d6002c35c02cfc9c5b219251f85180ad07">app/controllers/application_controller.rb</a>
    (18)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4197/files#diff-cf3fe9dc357f802fd9155582ffc8c6f71185065267991a2135323ad2d044b4f3">app/controllers/changesets_controller.rb</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4197/files#diff-961c5d7e0310073ca00d502eda2687808102441be660a654cab29645fbcea019">app/controllers/confirmations_controller.rb</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4197/files#diff-4b73866ef57c70fca07c0f330d7a57aae939b11e4aae0514f303df3aa3762f89">app/controllers/diary_entries_controller.rb</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4197/files#diff-61b51a87bb7b543e822aff82b71b37c768520f25fa60664aee9bb4e56af797ff">app/controllers/friendships_controller.rb</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4197/files#diff-9b58332ea76756301b1aafeacfb0659d1244ba014947602b0e0bf2d0f2921d26">app/controllers/messages_controller.rb</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4197/files#diff-c254740097a8c0601832077488db77e572b2c2b926f77508fadc6081b0052804">app/controllers/notes_controller.rb</a>
    (30)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4197/files#diff-2602c06a2618f83c1470c924563b55c738e3c94ffb6480e637ca0f4ce130eaba">app/controllers/traces_controller.rb</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4197/files#diff-5fb62154bcc2028d8f094225ee59e06e6dc57b853e0d429f7ebab0168f428111">app/controllers/user_blocks_controller.rb</a>
    (2)
  </li>
  <li>
    <strong>A</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4197/files#diff-68d2486b2ab9ee279f506ecd3d994b5cc4e994dbfa24881c536b1499870e4da6">app/controllers/user_resources_controller.rb</a>
    (23)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4197/files#diff-e84e62745ba4aecd60082e63ab314406d4080ba1bdf207620a0ddcf5ab5850d1">app/controllers/user_roles_controller.rb</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4197/files#diff-cfdccd0a9d5df5a43aaad2a35d36ebbe187c52ad5fdc9846fa189d04537adb6e">app/controllers/users_controller.rb</a>
    (2)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/4197.patch'>https://github.com/openstreetmap/openstreetmap-website/pull/4197.patch</a></li>
  <li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/4197.diff'>https://github.com/openstreetmap/openstreetmap-website/pull/4197.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4197">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLO3B2DESZGVACR34Y3XWNQVHANCNFSM6AAAAAA3YNIMFI">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLMLH2IH4XANHHWB53DXWNQVHA5CNFSM6AAAAAA3YNIMFKWGG33NNVSW45C7OR4XAZNFJFZXG5LFVJRW63LNMVXHIX3JMTHG5VCAV4.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/4197</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/4197",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/4197",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>