<p></p>
<p><b>@gravitystorm</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4202#discussion_r1310013605">app/controllers/api/changeset_comments_controller.rb</a>:</p>
<pre style='color:#555'>> @@ -17,6 +17,7 @@ def create
       # Check the arguments are sane
       raise OSM::APIBadUserInput, "No id was given" unless params[:id]
       raise OSM::APIBadUserInput, "No text was given" if params[:text].blank?
+      raise OSM::APIRateLimitExceeded if current_user.changeset_comments.where("created_at >= ?", Time.now.utc - 1.hour).count >= current_user.max_changeset_comments_per_hour
</pre>
<p dir="auto">might be better slightly abstracted - e.g. <code class="notranslate">raise OSM::APIRateLimitExceeded if rate_limit_exceeded</code> and the details put elsewhere, just to make the method easier to read.</p>
<p dir="auto">I know we have the method complexity metrics effectively disabled in rubocop, otherwise I'm sure it would have flagged this.</p>
<p dir="auto">(I'd also like to share limits between api vs website controllers in the long run, and so making reusable methods would be handy).</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4202#pullrequestreview-1602341521">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLK2JN35V7CHNXJSAADXX4E3ZANCNFSM6AAAAAA363PXKA">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLPUWIKCM36YHVSW3HDXX4E3ZA5CNFSM6AAAAAA363PXKCWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTS7QHFJC.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/4202/review/1602341521</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/4202#pullrequestreview-1602341521",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/4202#pullrequestreview-1602341521",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>