<p></p>
<p><b>@matkoniecz</b> commented on this pull request.</p>
<hr>
<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4202#discussion_r1310097388">app/models/user.rb</a>:</p>
<pre style='color:#555'>> @@ -395,6 +395,19 @@ def max_friends_per_hour
max_friends.clamp(0, Settings.max_friends_per_hour)
end
+ def max_changeset_comments_per_hour
+ if moderator?
+ 36000
+ else
+ previous_comments = changeset_comments.limit(200).count
+ active_reports = issues.with_status(:open).sum(:reports_count)
+ max_comments = previous_comments / 200.0 * Settings.max_changeset_comments_per_hour
+ max_comments = max_comments.floor.clamp(Settings.min_changeset_comments_per_hour, Settings.max_changeset_comments_per_hour)
+ max_comments /= 2**active_reports
+ max_comments.floor.clamp(1, Settings.max_changeset_comments_per_hour)
+ end
</pre>
<blockquote>
<p dir="auto">But in this case, a power user can be prevented from making more than 1 changeset comment per hour, by only a few (bogus) reports.</p>
</blockquote>
<p dir="auto">Maybe like proposed in <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="477236313" data-permission-text="Title is private" data-url="https://github.com/openstreetmap/openstreetmap-website/issues/2342" data-hovercard-type="issue" data-hovercard-url="/openstreetmap/openstreetmap-website/issues/2342/hovercard?comment_id=1694650004&comment_type=issue_comment" href="https://github.com/openstreetmap/openstreetmap-website/issues/2342#issuecomment-1694650004">#2342 (comment)</a> it would be possible to count how many users made reports against account, not simply how many reports were made? So simply making 100 bogus reports will not have so serious effects.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4202#discussion_r1310097388">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLIQQHJJNI5ATKEBY7LXX4NCPANCNFSM6AAAAAA363PXKA">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLOMRKSJZGHNISEMGZTXX4NCPA5CNFSM6AAAAAA363PXKCWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTS7QOCSS.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/4202/review/1602454825</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/4202#discussion_r1310097388",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/4202#discussion_r1310097388",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>