<p></p>
<p><b>@milan-cvetkovic</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4226#discussion_r1315184905">db/migrate/20230830115221_add_openid_scope.rb</a>:</p>
<pre style='color:#555'>> @@ -0,0 +1,11 @@
+class AddOpenidScope < ActiveRecord::Migration[7.0]
+  def self.up
+    add_column :oauth_tokens, :allow_openid, :boolean, :null => false, :default => false
+    add_column :client_applications, :allow_openid, :boolean, :null => false, :default => false
</pre>
<p dir="auto">Thanks for catching this. There is a number of classes used in both Oauth1 and Oauth2, for a moment I thought that these tables are used for both.</p>
<p dir="auto">It was my (failed) attempt to fix the Oauth1 tests failing due to new <code class="notranslate">openid</code> scope in <code class="notranslate">lib/oauth.rb</code>. I will have to take into account that this scope is <em>only</em> applicable to Oauth2,</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4226#discussion_r1315184905">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLI43RV3HQGD65ZEGK3XYYYMDANCNFSM6AAAAAA4KPKL4I">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLP3KG5YNVWA4TLD3E3XYYYMDA5CNFSM6AAAAAA4KPKL4KWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTS76WFOQ.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/4226/review/1609927400</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/4226#discussion_r1315184905",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/4226#discussion_r1315184905",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>