<p></p>
<p><b>@tomhughes</b> commented on this pull request.</p>

<p dir="auto">This is just an initial review of obvious things as I haven't looked at any of the details of the gem and how it works.</p><hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4226#discussion_r1314995659">db/migrate/20230830115220_validate_create_doorkeeper_openid_connect_tables.rb</a>:</p>
<pre style='color:#555'>> @@ -0,0 +1,5 @@
+class ValidateCreateDoorkeeperOpenidConnectTables < ActiveRecord::Migration[7.0]
</pre>
<p dir="auto">Why is this a separate migration? Can we not just include it in the previous migration that adds the tables?</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4226#discussion_r1314996064">db/migrate/20230830115221_add_openid_scope.rb</a>:</p>
<pre style='color:#555'>> @@ -0,0 +1,11 @@
+class AddOpenidScope < ActiveRecord::Migration[7.0]
+  def self.up
+    add_column :oauth_tokens, :allow_openid, :boolean, :null => false, :default => false
+    add_column :client_applications, :allow_openid, :boolean, :null => false, :default => false
</pre>
<p dir="auto">Why are we adding openid connect support to OAuth 1? That's not even a thing is it?</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4226#discussion_r1314996777">config/locales/doorkeeper_openid_connect.en.yml</a>:</p>
<pre style='color:#555'>> @@ -0,0 +1,23 @@
+en:
</pre>
<p dir="auto">You can just add extra local files like this - if the gem doesn't make these available automatically then you'll have to add them to the main <code class="notranslate">en.yml</code> file.</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4226#discussion_r1314998547">Gemfile</a>:</p>
<pre style='color:#555'>> @@ -78,6 +78,7 @@ gem "omniauth-rails_csrf_protection", "~> 1.0"
 
 # Doorkeeper for OAuth2
 gem "doorkeeper"
+gem "doorkeeper-openid_connect"
</pre>
<p dir="auto">Pretty sure rubocop is going to reject this as not correctly sorted - it will need to be moved after <code class="notranslate">doorkeeper-i18n</code>.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4226#pullrequestreview-1609627942">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLJDSEHUUTD5734BNBLXYXPCTANCNFSM6AAAAAA4KPKL4I">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLKABMJ6GKBM2THVMA3XYXPCTA5CNFSM6AAAAAA4KPKL4KWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTS76D4SM.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/4226/review/1609627942</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/4226#pullrequestreview-1609627942",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/4226#pullrequestreview-1609627942",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>