<p></p>
<p><b>@milan-cvetkovic</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4226#discussion_r1315049383">db/migrate/20230830115220_validate_create_doorkeeper_openid_connect_tables.rb</a>:</p>
<pre style='color:#555'>> @@ -0,0 +1,5 @@
+class ValidateCreateDoorkeeperOpenidConnectTables < ActiveRecord::Migration[7.0]
</pre>
<p dir="auto">Hm, db:migrate was failing due to possible deadlock when creating foreign keys and validating them in one shot, and suggested splitting to two migration scripts, which I did. I guess I could merge them into one.</p>
<p dir="auto">Here is the error message from db:migrate</p>
<blockquote>
<p dir="auto">=== Dangerous operation detected #strong_migrations ===</p>
<p dir="auto">Adding a foreign key blocks writes on both tables. Instead,<br>
add the foreign key without validating existing rows,<br>
then validate them in a separate migration.</p>
</blockquote>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4226#discussion_r1315049383">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLPXALLPAJGX2O4VBG3XYXVKXANCNFSM6AAAAAA4KPKL4I">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLJJEOOLZNYZBTGS53LXYXVKXA5CNFSM6AAAAAA4KPKL4KWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTS76I6W6.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/4226/review/1609710959</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/4226#discussion_r1315049383",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/4226#discussion_r1315049383",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>