<p dir="auto">This matches our usage of implicit style for associations generally, e.g. <code class="notranslate">user</code>.</p>
<p dir="auto">This isn't currently picked up by rubocop-factory_bot, due to a bug with the <a href="https://github.com/rubocop/rubocop-factory_bot/issues/53" data-hovercard-type="issue" data-hovercard-url="/rubocop/rubocop-factory_bot/issues/53/hovercard">default include paths</a>. Until the fix is released we can use the rubocop configuration to include our factories in the cop.</p>
<p dir="auto">While working with upstream <a href="https://github.com/rubocop/rubocop-factory_bot/pull/55" data-hovercard-type="pull_request" data-hovercard-url="/rubocop/rubocop-factory_bot/pull/55/hovercard">on a fix</a>, I realised I didn't like the output of the autocorrect. So since this change will need some manual input eventually, I thought I'd just do it sooner rather than later.</p>
<p dir="auto">(The autocorrect goes from <code class="notranslate">association :author, :factory => :user</code> to <code class="notranslate">author :factory => [:user]</code> but in our case there's no need for the array).</p>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/openstreetmap/openstreetmap-website/pull/4232'>https://github.com/openstreetmap/openstreetmap-website/pull/4232</a></p>

<h4>Commit Summary</h4>
<ul>
  <li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/4232/commits/cb4f99fef27bfe2269f688fd4d0a3f8ee0149de4" class="commit-link">cb4f99f</a>  Use implicit style for associations with factory overrides</li>
</ul>

<h4 style="display: inline-block">File Changes </h4> <p style="display: inline-block">(<a href="https://github.com/openstreetmap/openstreetmap-website/pull/4232/files">15 files</a>)</p>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4232/files#diff-4f894049af3375c2bd4e608f546f8d4a0eed95464efcdea850993200db9fef5c">.rubocop.yml</a>
    (5)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4232/files#diff-34fcd38c60059fb4c776850e7de782655e241941f676c189c76e38a2ab83f75e">test/factories/changeset_comments.rb</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4232/files#diff-fa05707ff8e9e60f7efcf5f8165ccb00d29bc249d297cd8eb699de9f742f461d">test/factories/friendships.rb</a>
    (4)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4232/files#diff-5c720e07d94f32830613a8a0e4a7193c714f51503e433a9afdb93082695a2710">test/factories/issues.rb</a>
    (4)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4232/files#diff-8a4bc2a52aa9d2d9c4ad6de08af530c771e2cd1fbe096df6c0bf81d869af20ee">test/factories/messages.rb</a>
    (4)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4232/files#diff-1673f60d01ff1b1eaa3c70a6dae8c7c1b65f0a882523dab1ba3a428542d9729b">test/factories/oauth_access_grant.rb</a>
    (4)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4232/files#diff-e5e1e11dbef11fb955376608e3054f5d459844110ececfe525686092831aea1c">test/factories/oauth_access_token.rb</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4232/files#diff-665e91619ed8cc70a9e8b5b6c52c4f2862b739593b15aded79bd9b21ad41f5a2">test/factories/oauth_applications.rb</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4232/files#diff-3bbcddfd07118a6a6bfabfe7125c6dcbcec13e7da33ce11ba7d716858a546b2d">test/factories/old_node.rb</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4232/files#diff-3dc9f637f847df917595a2803108e18b65a5558b5e962d41d99861af9442ee1d">test/factories/old_relation.rb</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4232/files#diff-9dd74204549cecbe552eed211fa7bff661bb4b4bcca32c2844164118b4e77c09">test/factories/old_relation_member.rb</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4232/files#diff-5142096a0309eaa120fe18dc61e260fe9c3b2980e292f879313301fe51458c5a">test/factories/old_way.rb</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4232/files#diff-41f80dd7fe83fa4c4ff9472b9623d25fb68e0520f2cdb9390c42384475835698">test/factories/relation_member.rb</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4232/files#diff-b6c0b1af31522c030e07c403d8ca797f366f31cffac84e321df63bbc0febca13">test/factories/user_blocks.rb</a>
    (4)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4232/files#diff-69a125524d888680c8a7556970da4470c02a2d6aa5e5ac90c0fff2a40dddee88">test/factories/user_role.rb</a>
    (2)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/4232.patch'>https://github.com/openstreetmap/openstreetmap-website/pull/4232.patch</a></li>
  <li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/4232.diff'>https://github.com/openstreetmap/openstreetmap-website/pull/4232.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4232">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLOBJXT66X7RX6SH6ATXZA65TANCNFSM6AAAAAA4NA22B4">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLPPOPGGHVB3ILWPWALXZA65TA5CNFSM6AAAAAA4NA22B6WGG33NNVSW45C7OR4XAZNFJFZXG5LFVJRW63LNMVXHIX3JMTHHARN534.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/4232</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/4232",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/4232",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>