<p></p>
<p><b>@milan-cvetkovic</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4226#discussion_r1318885342">config/initializers/doorkeeper_openid_connect.rb</a>:</p>
<pre style='color:#555'>> @@ -27,12 +27,36 @@
   end
 
   claims do
-    claim :preferred_username, :scope => :openid do |resource_owner, _scopes, _access_token|
+    claim :preferred_username, :response => [:id_token, :user_info] do |resource_owner, _scopes, _access_token|
</pre>
<p dir="auto">I guess it is not strictly required either way. <a href="https://openid.net/specs/openid-connect-core-1_0.html#ScopeClaims" rel="nofollow">https://openid.net/specs/openid-connect-core-1_0.html#ScopeClaims</a> associates <code class="notranslate">preferred_username</code> with <code class="notranslate">profile</code> scope. However my tests with some providers show that it is returned when only <code class="notranslate">openid</code> scope is requested.</p>
<p dir="auto">Contrary to the spec, they show up in id_token in addition to showing up in response to userinfo endpoint.</p>
<p dir="auto">I was under the impression that you geared towards having <code class="notranslate">profile</code> scope with at least <code class="notranslate">profile</code> claim.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4226#discussion_r1318885342">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLLHOYE3N3K5FM2TSFDXZH3Q7ANCNFSM6AAAAAA4KPKL4I">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLOLJYM5FANHUPCEUGTXZH3Q7A5CNFSM6AAAAAA4KPKL4KWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTTAKA62O.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/4226/review/1615871399</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/4226#discussion_r1318885342",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/4226#discussion_r1318885342",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>