<p dir="auto">This PR removes the remaining usage of the Sass division operator in our stylesheets.</p>
<p dir="auto"><a href="https://sass-lang.com/documentation/breaking-changes/slash-div/" rel="nofollow">https://sass-lang.com/documentation/breaking-changes/slash-div/</a></p>
<p dir="auto">Whereever practicable, I've done this by refactoring the way that our styles work in order to remove the need for the custom css rules. In a few situations I took the "easy option" and converted the division to a multiplication instead, for the sake of time.</p>
<p dir="auto">This work is a pre-requisite for moving to dartsass for compiling our stylesheets (the <code class="notranslate">sassc</code> gem, and the libsass project it uses, are both abandoned at this point, in favour of dartsass). And moving to dartsass (using <code class="notranslate">dartsass-sprockets</code>) is a prerequisite for us upgrading to newer versions of Bootstrap, which are incompatible with libsass.</p>
<hr>
<h4>You can view, comment on, or merge this pull request online at:</h4>
<p> <a href='https://github.com/openstreetmap/openstreetmap-website/pull/4247'>https://github.com/openstreetmap/openstreetmap-website/pull/4247</a></p>
<h4>Commit Summary</h4>
<ul>
<li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/4247/commits/79868aeae7c0023e510d446cb4efb890da644917" class="commit-link">79868ae</a> Remove unnecessary paragraph margin override on diary comments</li>
<li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/4247/commits/ffe637f23d81a9e9ba769020ad0ffbb04a5e3a7d" class="commit-link">ffe637f</a> Use multiplication for secondary-actions margin and padding</li>
<li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/4247/commits/0a41b19bbcf1e814046c7dfdb91b16c40acb6fb2" class="commit-link">0a41b19</a> Use an inline list for the login auth buttons</li>
<li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/4247/commits/d45c1435e6649c6af91d5799a5162dfaa661c72b" class="commit-link">d45c143</a> Use spacer for margins on leaflet popups</li>
<li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/4247/commits/5473be178a37427d173043a3ed198920a1b2deb2" class="commit-link">5473be1</a> Refactor the directions table to use bootstrap table styling</li>
<li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/4247/commits/3c4f48e59b7c4146f35f4442ce3cdc034eae4871" class="commit-link">3c4f48e</a> Remove custom styling from export alternative sources dl</li>
<li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/4247/commits/5d4c96878a6c335b3f4216a81a60f2da27f3c82c" class="commit-link">5d4c968</a> Remove sass division for export input boxes margins</li>
<li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/4247/commits/f3a44431205f23592a17efba753f1087bfcf2cf0" class="commit-link">f3a4443</a> Remove unusual margins and line-height from comments</li>
<li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/4247/commits/841cff678bc76179dd58c319c7dd09dd9dffe9dc" class="commit-link">841cff6</a> Refactor remaining sass division operators to use multiplication</li>
</ul>
<h4 style="display: inline-block">File Changes </h4> <p style="display: inline-block">(<a href="https://github.com/openstreetmap/openstreetmap-website/pull/4247/files">6 files</a>)</p>
<ul>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/4247/files#diff-fdb9558c2ba79ddf9fbcb92594a8a8fa54abb1b3e25ce264de37951b428a958b">app/assets/javascripts/index/directions.js</a>
(7)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/4247/files#diff-e86a39e6d0b163f152db8843fc7d647a3f5d648de4a74f1732bef4474b6e5bc8">app/assets/stylesheets/common.scss</a>
(52)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/4247/files#diff-fba7159a4abd78f8b24f765a0c58ebe47a24be99e185c373175f20f612a5d781">app/views/browse/changeset.html.erb</a>
(8)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/4247/files#diff-84d04c9c37a8be927ab1870e6b3c1940f670585b77b8e88c32d6ded35cf87dc7">app/views/notes/show.html.erb</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/4247/files#diff-5654cfc158c888a40321c1e90f9ea3a0208ae80616b15ff0fa5e939b8f795e87">app/views/sessions/new.html.erb</a>
(22)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/4247/files#diff-db1600b3df800c073c8d2ff04b1f5042902abcb20b0a55729ddeca8d23012ea5">app/views/site/export.html.erb</a>
(4)
</li>
</ul>
<h4>Patch Links:</h4>
<ul>
<li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/4247.patch'>https://github.com/openstreetmap/openstreetmap-website/pull/4247.patch</a></li>
<li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/4247.diff'>https://github.com/openstreetmap/openstreetmap-website/pull/4247.diff</a></li>
</ul>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4247">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLNP2G2LXE3J3DGKYSDX2HJ7BANCNFSM6AAAAAA4WVIA5E">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLJOXFKXA3SCVNW5RBLX2HJ7BA5CNFSM6AAAAAA4WVIA5GWGG33NNVSW45C7OR4XAZNFJFZXG5LFVJRW63LNMVXHIX3JMTHHB4GQ4E.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/4247</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/4247",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/4247",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>