<p></p>
<p><b>@gravitystorm</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4248#discussion_r1326279791">config/routes.rb</a>:</p>
<pre style='color:#555'>>    resources :notes, :path => "note", :only => [:show, :new]
 
   get "/user/:display_name/history" => "changesets#index"
   get "/user/:display_name/history/feed" => "changesets#feed", :defaults => { :format => :atom }
+  get "/user/:display_name/history/comments" => "changeset_comments#index", :as => :history_comments
</pre>
<p dir="auto">We should try to avoid the <code class="notranslate">:as</code> setting entirely. As we move to more resourceful routing, it becomes less and less necessary. Generally we want to use resourceful routing, and accept the auto generated route names as-is.</p>
<p dir="auto">I need to think about the controller structure for this PR. I know that (ignoring the API) we've currently got a flat hierarchy of controllers, but this approach has disadvantages. For example, it's not clear that <code class="notranslate">app/controllers/changeset_comments_controller.rb#index</code> would be a user-scoped subset of changeset comments, and it would clash with any implementation of site-wide changeset_comments#index (e.g. for moderation). I want to consider the pros and cons of having a <code class="notranslate">user/changeset_comments</code> controller but I need to play around with that.</p>
<p dir="auto">In any case, I would ask for resourceful routing here.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4248#discussion_r1326279791">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLLR3I4HJO65L6JSH23X2M2CNANCNFSM6AAAAAA4YHSQ4E">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLLKSESKPOXQBMEHGVTX2M2CNA5CNFSM6AAAAAA4YHSQ4GWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTTA77ZKW.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/4248/review/1627386539</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/4248#discussion_r1326279791",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/4248#discussion_r1326279791",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>