<p></p>
<p><b>@tomhughes</b> commented on this pull request.</p>

<p dir="auto">I wonder if we should merge note comments under this interface eventually, and make the current user notes view just show notes they opened and not every comment - maybe as part of the planned restructuring of notes to make notes less linked to the initial comment.</p><hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4248#discussion_r1326225850">config/locales/en.yml</a>:</p>
<pre style='color:#555'>> @@ -548,10 +550,12 @@ en:
         description: "Recent diary entries from users of OpenStreetMap"
     comments:
       title: "Diary Comments added by %{user}"
-      heading: "%{user}'s Diary Comments"
-      subheading_html: "Diary Comments added by %{user}"
-      no_comments: "No diary comments"
+      heading_html: "%{user}'s Comments"
+      for_diary: "For diary"
+      for_history: "For map edits"
</pre>
<p dir="auto">I don't think the "For" prefix reads very well here and there's also inconsistent pluralisation between the two tabs. I think I would just go with <code class="notranslate">Diaries</code> or <code class="notranslate">Diary entries</code> for the first one and <code class="notranslate">Changesets</code> for the second - we could do <code class="notranslate">Map edits</code> but we already using changesets in other places so I think we should be consistent.</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4248#discussion_r1326228653">config/routes.rb</a>:</p>
<pre style='color:#555'>>    resources :notes, :path => "note", :only => [:show, :new]
 
   get "/user/:display_name/history" => "changesets#index"
   get "/user/:display_name/history/feed" => "changesets#feed", :defaults => { :format => :atom }
+  get "/user/:display_name/history/comments" => "changeset_comments#index", :as => :history_comments
</pre>
<p dir="auto">I think we should use <code class="notranslate">changeset_comments</code> as the route name. I know that, for hysterical raisins, we use <code class="notranslate">history</code> in the URL but the controller is called <code class="notranslate">changeset_comments</code>.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4248#pullrequestreview-1627320378">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLNLK6NCJ5MIVXMWRSTX2MXHTANCNFSM6AAAAAA4YHSQ4E">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLOQ3CUYKO7LLQHNNPLX2MXHTA5CNFSM6AAAAAA4YHSQ4GWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTTA73YDU.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/4248/review/1627320378</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/4248#pullrequestreview-1627320378",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/4248#pullrequestreview-1627320378",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>