<p></p>
<p dir="auto">Yes, I <em>almost</em> agree with requirement (as you <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/gravitystorm/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/gravitystorm">@gravitystorm</a> put it). I would just append to it "when on openstreetmap.org website".</p>
<p dir="auto">It is about making sure that message(s) contained in welcome screen are delivered to the user. I think it is up to third-party app's responsibility to deliver these messages in a manner that is as similar and as prominent as <code class="notranslate">/welcome</code> page! When/if user visits later osm.org or osm.org/edit, it should be given opportunity to see welcome page. But in OAuth signup flow, yet another dialog to click is just hurting conversion rate (both for third-party app and for OSM). Does this makes sense to you?</p>
<p dir="auto">If it is, let me immediately give one possible proposal. We would work on implementation (with your hand-holding when necessary):</p>
<ul dir="auto">
<li>We introduce new <code class="notranslate">bool</code> column in <code class="notranslate">users</code> table named <code class="notranslate">welcome_seen</code> (defaults to true, not null) (we think there is no perf hits/locks in postgres to do this, even in huge tables)</li>
<li>All existing users would have <code class="notranslate">welcome_seen</code> set to true, as <code class="notranslate">/welcome</code> page is seen (honors current reality).</li>
<li>When new user is created in DB, we set this to false initially.</li>
<li>As login flow continues to guide users to <code class="notranslate">/welcome</code> page, <code class="notranslate">/welcome</code> page (on GET request) sets this bit to true for currently logged-in users (this can be done unconditionally, as this bit can never go true->false)</li>
<li>OAuth signup skips <code class="notranslate">/welcome</code> page and keep <code class="notranslate">welcome_seen</code> to false.</li>
<li>We add checks in <code class="notranslate">/</code> and <code class="notranslate">/edit</code> routes to read <code class="notranslate">welcome_seen</code> field and either show nice HTML closable dialog, or just simply redirect users to <code class="notranslate">/welcome</code> page reusing current page (but keeps redirects and URL parameters to bring user back where they originated from).</li>
</ul>
<p dir="auto">We don't mind other solutions as well (for example with welcome being mail), but it is really important that OAuth signup flow is uninterrupted and that conversion is maximized.</p>
<p dir="auto">Feel free to comment on proposal (does it make sense at all, any problems...), and let's come up with solution that works for all!</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/issues/4246#issuecomment-1730102639">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLMYIVR5SIKZSPVMY5LX3SCD5ANCNFSM6AAAAAA4WTGC3M">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLM2AW5OVC2C446UUOTX3SCD5A5CNFSM6AAAAAA4WTGC3OWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTTHD5CW6.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/issues/4246/1730102639</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/issues/4246#issuecomment-1730102639",
"url": "https://github.com/openstreetmap/openstreetmap-website/issues/4246#issuecomment-1730102639",
"name": "View Issue"
},
"description": "View this Issue on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>