<p></p>
<p><b>@tomhughes</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4278#discussion_r1355570644">test/controllers/api/nodes_controller_test.rb</a>:</p>
<pre style='color:#555'>> @@ -138,7 +138,7 @@ def test_create_invalid_xml
       xml = "<osm><node lat='#{lat}' lon='#{lon}' changeset='#{changeset.id}'><tag k='foo' v='#{'x' * 256}'/></node></osm>"
       put node_create_path, :params => xml, :headers => auth_header
       assert_response :bad_request, "node upload did not return bad_request status"
-      assert_equal ["NodeTag ", " v: is too long (maximum is 255 characters) (\"#{'x' * 256}\")"], @response.body.split(/[0-9]+,foo:/)
</pre>
<p dir="auto">I remembered the details slightly wrong... This is what it used to look like:</p>
<pre class="notranslate"><code class="notranslate">NodeTag 14,foo: v: is too long (maximum is 255 characters)
</code></pre>
<p dir="auto">and now:</p>
<pre class="notranslate"><code class="notranslate">NodeTag [38, "foo"]: v: is too long (maximum is 255 characters)
</code></pre>
<p dir="auto">which is all down to how rails default error handling (augmented by CPK in the old code) represents a composite key in a validation failure which I'm not sure we can do much about?</p>
<p dir="auto">Are users really supposed to be parsing this?</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4278#discussion_r1355570644">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLPG6ZWA5BKPNDSXFBTX63QBBANCNFSM6AAAAAA5XRWRQY">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLIMEAPAV7F6MJGNP23X63QBBA5CNFSM6AAAAAA5XRWRQ2WGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTTDVQFCY.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/4278/review/1672219180</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/4278#discussion_r1355570644",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/4278#discussion_r1355570644",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>