<p></p>
<p><b>@mmd-osm</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4278#discussion_r1355752853">test/controllers/api/nodes_controller_test.rb</a>:</p>
<pre style='color:#555'>> @@ -138,7 +138,7 @@ def test_create_invalid_xml
       xml = "<osm><node lat='#{lat}' lon='#{lon}' changeset='#{changeset.id}'><tag k='foo' v='#{'x' * 256}'/></node></osm>"
       put node_create_path, :params => xml, :headers => auth_header
       assert_response :bad_request, "node upload did not return bad_request status"
-      assert_equal ["NodeTag ", " v: is too long (maximum is 255 characters) (\"#{'x' * 256}\")"], @response.body.split(/[0-9]+,foo:/)
</pre>
<p dir="auto">FWIW: I invented my own error messages in cgimap for keys/values exceeding 255 chars, and nobody seemed to have an issue with it. That's for the diff upload, though.</p>
<p dir="auto">Error messages are: <em>Key has more than 255 unicode characters</em> and <em>Value has more than 255 unicode characters</em>.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4278#discussion_r1355752853">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLPP7B5A6JLABR7XOCLX637ORANCNFSM6AAAAAA5XRWRQY">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLKAK2I5TQ2H2WOSYOLX637ORA5CNFSM6AAAAAA5XRWRQ2WGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTTDWDYKY.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/4278/review/1672540332</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/4278#discussion_r1355752853",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/4278#discussion_r1355752853",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>