<p dir="auto"><span class="issue-keyword tooltipped tooltipped-se" aria-label="This pull request closes issue #3613.">Fixes</span> <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="1314453026" data-permission-text="Title is private" data-url="https://github.com/openstreetmap/openstreetmap-website/issues/3613" data-hovercard-type="issue" data-hovercard-url="/openstreetmap/openstreetmap-website/issues/3613/hovercard" href="https://github.com/openstreetmap/openstreetmap-website/issues/3613">#3613</a></p>
<p dir="auto">One line change to add "localhost" to the list of allowed OAuth2 http redirects (along with 127.0.0.1 currently).</p>
<p dir="auto">As suggested by this comment: <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="1314453026" data-permission-text="Title is private" data-url="https://github.com/openstreetmap/openstreetmap-website/issues/3613" data-hovercard-type="issue" data-hovercard-url="/openstreetmap/openstreetmap-website/issues/3613/hovercard?comment_id=1193399513&comment_type=issue_comment" href="https://github.com/openstreetmap/openstreetmap-website/issues/3613#issuecomment-1193399513">#3613 (comment)</a> the security implications should be minimal.</p>
<p dir="auto">localhost should resolve to loopback 127.0.0.1 on most systems and the auth code obtained should not be leaked externally.<br>
The circumstance where this is in issue is on compromised systems, where the DNS resolution can be manipulated.</p>
<hr>
<h4>You can view, comment on, or merge this pull request online at:</h4>
<p> <a href='https://github.com/openstreetmap/openstreetmap-website/pull/4287'>https://github.com/openstreetmap/openstreetmap-website/pull/4287</a></p>
<h4>Commit Summary</h4>
<ul>
<li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/4287/commits/f14b932b5820fb3415be26713809e0615d25dc50" class="commit-link">f14b932</a> fix(oauth): add localhost to allowed http redirect_uris</li>
</ul>
<h4 style="display: inline-block">File Changes </h4> <p style="display: inline-block">(<a href="https://github.com/openstreetmap/openstreetmap-website/pull/4287/files">1 file</a>)</p>
<ul>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/4287/files#diff-c7fc4e057f18c41db72e3ab775f9871e6bee4d7e2b0aba1fdbfb2ea209dd2141">config/initializers/doorkeeper.rb</a>
(4)
</li>
</ul>
<h4>Patch Links:</h4>
<ul>
<li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/4287.patch'>https://github.com/openstreetmap/openstreetmap-website/pull/4287.patch</a></li>
<li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/4287.diff'>https://github.com/openstreetmap/openstreetmap-website/pull/4287.diff</a></li>
</ul>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4287">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLNVOGBPMJXHX6LTSRDX666TDANCNFSM6AAAAAA55LRREU">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLLXJRNN32VKFATOFZTX666TDA5CNFSM6AAAAAA55LRREWWGG33NNVSW45C7OR4XAZNFJFZXG5LFVJRW63LNMVXHIX3JMTHHHHGRME.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/4287</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/4287",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/4287",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>