<p></p>
<p><b>@milan-cvetkovic</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4288#discussion_r1358483731">config/locales/en.yml</a>:</p>
<pre style='color:#555'>> @@ -1594,6 +1594,90 @@ en:
       greeting: "Hi,"
       hopefully_you: "Someone (hopefully you) would like to change their email address over at %{server_url} to %{new_address}."
       click_the_link: "If this is you, please click the link below to confirm the change."
+    welcome_email:
+      subject: "[OpenStreetMap] Welcome!"
</pre>
<p dir="auto">I am not really sure how to reduce the duplication of messages for welcome email welcome screen.</p>
<p dir="auto">It looks like the template files need to be stored in specific directories: <code class="notranslate">views/user_mailer/welcome_email.*.erb</code> and <code class="notranslate">views/site/welcome.html.erb</code> - so we cannot reuse the same template file.</p>
<p dir="auto">I could potentially reuse the strings - use <code class="notranslate">layouts/site/welcome</code> strings instead of <code class="notranslate">layouts/user_mailer/welcome_email</code> in <code class="notranslate">views/user_mailer/welcome_email.*.erb</code>, but that didn't seem to be clean.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4288#pullrequestreview-1676847852">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLP7RCGMUP4XV6EZPE3X7FTM5ANCNFSM6AAAAAA57L2W2A">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLNARPB6R4LR57MQI6LX7FTM5A5CNFSM6AAAAAA57L2W2CWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTTD6KVOY.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/4288/review/1676847852</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/4288#pullrequestreview-1676847852",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/4288#pullrequestreview-1676847852",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>