<p></p>
<p><b>@gravitystorm</b> commented on this pull request.</p>
<hr>
<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4284#discussion_r1367758826">app/controllers/messages_controller.rb</a>:</p>
<pre style='color:#555'>> @@ -127,6 +134,23 @@ def mark
render :action => "no_such_message", :status => :not_found
end
+ # Moves message into Inbox by unsetting the muted-flag
+ def unmute
+ message = Message.where(:recipient => current_user).find(params[:message_id])
</pre>
<p dir="auto">We prefer <code class="notranslate">find_by</code> instead of <code class="notranslate">where().first</code>, but <code class="notranslate">Model.find(id)</code> is still preferred to <code class="notranslate">Model.find_by(:id => id)</code>.</p>
<p dir="auto">I think some kind of scoping is necessary to avoid unmuting other people's messages, although I'd normally try to find a <code class="notranslate">current_user.something.find()</code> to scope them rather than building a where query.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4284#discussion_r1367758826">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLPC3FWKJI3CN2FR4GLYAP3DLAVCNFSM6AAAAAA53SDOR2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTMOJRGI4TAMBTGE">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLILMHV2B27PZH5DBKTYAP3DLA5CNFSM6AAAAAA53SDOR2WGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTTEZ4E26.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/4284/review/1691290031</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/4284#discussion_r1367758826",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/4284#discussion_r1367758826",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>