<p dir="auto">As I posted in the dwg chat:</p>
<ul dir="auto">
<li>the delay is 1 day to make sure that there are no open changesets when users are deleted</li>
<li>there's a setting, delays are disabled when set to 0</li>
<li>I assumed that no possible law/regulation can exist that would require us to act faster than within a day</li>
<li>no checks if the user is blocked, only the last changeset opening time</li>
<li>I'd check the closing time, but there's no index together with uid</li>
</ul>
<hr>
<h4>You can view, comment on, or merge this pull request online at:</h4>
<p> <a href='https://github.com/openstreetmap/openstreetmap-website/pull/4313'>https://github.com/openstreetmap/openstreetmap-website/pull/4313</a></p>
<h4>Commit Summary</h4>
<ul>
<li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/4313/commits/4dce364158e28953acf88f16349c58a9472a2e1d" class="commit-link">4dce364</a> Add user account deletion delay test helper</li>
<li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/4313/commits/f2eee68a47695357dedee7c3fc8d69467d208589" class="commit-link">f2eee68</a> Add earliest allowed deletion time to user model</li>
<li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/4313/commits/8f1de00e188498d54be9cc864bf4caf19acf065a" class="commit-link">8f1de00</a> Disable delete account button if there are recent changesets</li>
<li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/4313/commits/cd633ca12562dcc62db1d18d3150610f64916206" class="commit-link">cd633ca</a> Disallow account deletion after confirmation</li>
</ul>
<h4 style="display: inline-block">File Changes </h4> <p style="display: inline-block">(<a href="https://github.com/openstreetmap/openstreetmap-website/pull/4313/files">11 files</a>)</p>
<ul>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/4313/files#diff-02739344243c100a83779d064913eab2c537d6c5c5910abd7629c1ec91486df2">app/controllers/account/deletions_controller.rb</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/4313/files#diff-25fe163085ea55de795324d01f141d5e4de00c6a2d3035d75c6e0768af679a2e">app/controllers/accounts_controller.rb</a>
(14)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/4313/files#diff-5f3fc5e3977d242572aa1d08551f5eb557de0ccaff30370838ee9df5386ea0da">app/helpers/application_helper.rb</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/4313/files#diff-9802ca3c9c4cf89904fd44bc114e35ebdf2c5dd3d5b645491e2b253e1afef29b">app/models/user.rb</a>
(8)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/4313/files#diff-8f87f7dfdba7dbded094bab5b6fa14deac0258fe482f50b79db021bbd4f28786">app/views/account/deletions/show.html.erb</a>
(10)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/4313/files#diff-44438ce218f5287c58d0017f965d888715635d94280669896f75841fbd7b4cd7">config/locales/en.yml</a>
(1)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/4313/files#diff-e769bbb8c1ba3711c5403b424ed9c218ffafba7f1890ee394717196f28ff4540">config/settings.yml</a>
(2)
</li>
<li>
<strong>A</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/4313/files#diff-47f0cd70fa8115d637d946c56bdfe406eef1989ecec308e059f39d4ba29aaa34">test/controllers/account/deletions_controller_test.rb</a>
(65)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/4313/files#diff-42f978077b25d17cae9dd23c5ad1bbdae876875f7f32e5b9630f316034d25885">test/controllers/accounts_controller_test.rb</a>
(19)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/4313/files#diff-91bef9fda3c55514e23a4a8edba948f68aad59b57951adcff0b11e9ea9159854">test/models/user_test.rb</a>
(38)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/4313/files#diff-ba37813ca277c227a74a372479b7b05b7f3ff085d890ab708f80d62573efdb7a">test/test_helper.rb</a>
(11)
</li>
</ul>
<h4>Patch Links:</h4>
<ul>
<li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/4313.patch'>https://github.com/openstreetmap/openstreetmap-website/pull/4313.patch</a></li>
<li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/4313.diff'>https://github.com/openstreetmap/openstreetmap-website/pull/4313.diff</a></li>
</ul>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4313">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLI5VGWNSCPNU4LRWW3YBADC5AVCNFSM6AAAAAA6OENTSGVHI2DSMVQWIX3LMV43ASLTON2WKOZRHE2TSOBUHEZTEMQ">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLI2HPI3SMZHZQYPFW3YBADC5A5CNFSM6AAAAAA6OENTSGWGG33NNVSW45C7OR4XAZNFJFZXG5LFVJRW63LNMVXHIX3JMTHHJUHNNI.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/4313</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/4313",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/4313",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>