<p></p>
<p dir="auto">I'm happy with the change. I'd like to suggest a different approach in the tests. Since the actual values of the <code class="notranslate">sequence_id</code> aren't important (they are never displayed anywhere, they just need to be larger and different than the previously used one) then we can use a Factorybot sequence for them:</p>
<div class="highlight highlight-source-diff" dir="auto"><pre class="notranslate"> FactoryBot.define do
   factory :relation_member do
<span class="pl-md"><span class="pl-md">-</span>    sequence_id { 1 }</span>
<span class="pl-mi1"><span class="pl-mi1">+</span>    sequence(:sequence_id)</span></pre></div>
<div class="highlight highlight-source-diff" dir="auto"><pre class="notranslate"> FactoryBot.define do
   factory :old_relation_member do
<span class="pl-mi1"><span class="pl-mi1">+</span>    sequence(:sequence_id)</span>
     member_role { "" }</pre></div>
<p dir="auto">Then we don't have to introduce all the explicit references to sequence_ids elsewhere in the tests. They'll be incremented automatically (albeit not starting from 1 for each relation, but who cares), and can still be overridden when necessary.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4300#issuecomment-1780892696">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLOUNBWHNJJAT5XOPJDYBI7E5AVCNFSM6AAAAAA6FYQFWGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOBQHA4TENRZGY">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLLQ7ZVRYSMES3K3YPLYBI7E5A5CNFSM6AAAAAA6FYQFWGWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTTKEZCBQ.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/4300/c1780892696</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/4300#issuecomment-1780892696",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/4300#issuecomment-1780892696",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>