<p></p>
<p><b>@grekko</b> commented on this pull request.</p>
<hr>
<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4284#discussion_r1373679539">test/models/user_mute_test.rb</a>:</p>
<pre style='color:#555'>> + create(:user_mute, :owner => user, :subject => muted_user)
+
+ message = build(:message, :sender => muted_user, :recipient => user)
+ message.save
+
+ assert_predicate message, :muted?
+ end
+
+ def test_messages_by_admins_or_moderators_are_never_muted
+ user = create(:user)
+
+ [create(:administrator_user), create(:moderator_user)].each do |admin_or_moderator|
+ create(:user_mute, :owner => user, :subject => admin_or_moderator)
+
+ message = build(:message, :sender => admin_or_moderator, :recipient => user)
+ message.save
</pre>
<p dir="auto">🤔 yeah, I would expect so. I am not sure the code calls <code class="notranslate">build</code> and <code class="notranslate">save</code> – I think this can and should just be <code class="notranslate">create</code> – thanks!</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4284#discussion_r1373679539">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLNNV5RJWEHA6IWZKULYBKXJPAVCNFSM6AAAAAA53SDOR2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTOMBQGQ2DINZZG4">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLKWDUDUH6RQAKHUP5TYBKXJPA5CNFSM6AAAAAA53SDOR2WGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTTFLK5H2.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/4284/review/1700444797</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/4284#discussion_r1373679539",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/4284#discussion_r1373679539",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>