<p dir="auto"><a target="_blank" rel="noopener noreferrer" href="https://user-images.githubusercontent.com/4158490/282279787-838697fa-fe2d-4821-b20b-511f27aaa787.png"><img src="https://user-images.githubusercontent.com/4158490/282279787-838697fa-fe2d-4821-b20b-511f27aaa787.png" alt="image" style="max-width: 100%;"></a></p>
<p dir="auto">It would make sense to have two different sidebars if you need them both open at the same time. I don't think this is the case.</p>
<p dir="auto">Having only one sidebar might be better because:</p>
<ul dir="auto">
<li>no extra code for sidebar on the right</li>
<li>buttons on the right side don't move anywhere when pressed</li>
<li>urls for opened layers/key/share sidebars</li>
<li>allows to move most of the layers/key/share html construction code to erb templates</li>
</ul>
<p dir="auto">and might be worse because:</p>
<ul dir="auto">
<li>layers/key/share sidebar is opened on the opposite side to the buttons (but <em>add note</em> and <em>query features</em> already use left sidebar)</li>
<li>have to add and maintain routes for layers/key/share (possible to avoid, but need to decide how back/forward navigation is going to work)</li>
</ul>
<p dir="auto">Most of the changes are moving code from <code class="notranslate">app/assets/javascripts/leaflet.*.js</code> to <code class="notranslate">app/assets/javascripts/index/*.js</code> and <code class="notranslate">app/views/site/*.html.erb</code>.</p>
<hr>
<h4>You can view, comment on, or merge this pull request online at:</h4>
<p> <a href='https://github.com/openstreetmap/openstreetmap-website/pull/4335'>https://github.com/openstreetmap/openstreetmap-website/pull/4335</a></p>
<h4>Commit Summary</h4>
<ul>
<li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/4335/commits/58c20073a37a640a34d84c9584df03b721e10a63" class="commit-link">58c2007</a> Move map key to left sidebar</li>
<li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/4335/commits/5e6865758300eccf74ccbe7320cac19aa21a8514" class="commit-link">5e68657</a> Move layers ui to left sidebar</li>
<li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/4335/commits/15a363e1dfdd61bc8f4aa09ea5add1b10bdd8587" class="commit-link">15a363e</a> Write layer sections in erb template</li>
<li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/4335/commits/533a6101faa950fb19079abfbc561f0b936bd1f9" class="commit-link">533a610</a> Write overlay layer inputs in erb template</li>
<li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/4335/commits/035e5935a31c4569ccf54d2d92373ee576e59390" class="commit-link">035e593</a> Enable/disable overlay layer event handlers in page.load/unload</li>
<li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/4335/commits/4931fcbf7802158aa87482cf68624cfdbe04c193" class="commit-link">4931fcb</a> Remove base layer switch listeners on page unload</li>
<li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/4335/commits/d889e3c81474f58f0ce406a3ad11b39688eaa703" class="commit-link">d889e3c</a> Move share pane to left sidebar</li>
<li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/4335/commits/4c3d85ed02da171e96be32c7af489796c68b9d5b" class="commit-link">4c3d85e</a> Remove unused right sidebar pane module</li>
<li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/4335/commits/3a29fa5f2a6fbbd5f7dc2cec705fef65211080cb" class="commit-link">3a29fa5</a> Remove share map event handlers on page unload</li>
<li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/4335/commits/91ac03d562e811653cdd3c3d8a2fbfde49fb3667" class="commit-link">91ac03d</a> Update sidebar section styles</li>
<li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/4335/commits/bc5142a581ba2c927731ef8c20275f1e63ac99c7" class="commit-link">bc5142a</a> Remove unused right sidebar code</li>
<li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/4335/commits/377b4c0e2df98ec882bb1dedb026422fa55490c6" class="commit-link">377b4c0</a> Write share sections in erb template</li>
<li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/4335/commits/1d3ee9a91e782df671565bfeb542142fdc9ffd4c" class="commit-link">1d3ee9a</a> Write share controls in erb template</li>
</ul>
<h4 style="display: inline-block">File Changes </h4> <p style="display: inline-block">(<a href="https://github.com/openstreetmap/openstreetmap-website/pull/4335/files">20 files</a>)</p>
<ul>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/4335/files#diff-debf59904131dc89a88ab44cbb1d6deaaa5a7d70c0507f674080df62f7c8e41f">app/abilities/ability.rb</a>
(3)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/4335/files#diff-cdc070ced1c4000efd1e28357fd26b2fd617d7fccfeae0324222231db75dd6ee">app/assets/javascripts/index.js</a>
(40)
</li>
<li>
<strong>A</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/4335/files#diff-a75949e8df046bc188902c6195f1d0273f486d641bab5e3e5095e9aae30852c2">app/assets/javascripts/index/layers.js</a>
(192)
</li>
<li>
<strong>A</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/4335/files#diff-acfc8da48c84dc030350fff6edfd4c5fc8109ba69dbcf63c546df2f9296af934">app/assets/javascripts/index/mapkey.js</a>
(44)
</li>
<li>
<strong>A</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/4335/files#diff-0e4c1b80db22c002a7ec77cdce3660261dbf4cedebc82697db21d61414190c2b">app/assets/javascripts/index/share.js</a>
(229)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/4335/files#diff-08a7ab143240d1f24d2cfc6f105ae9a1d8bc7fc5d1b95a280cb8a76180e93397">app/assets/javascripts/leaflet.key.js</a>
(48)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/4335/files#diff-87e33ea7d5e625dd851a78a3192719681de20caea8edd278a10f5342585c98e7">app/assets/javascripts/leaflet.layers.js</a>
(167)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/4335/files#diff-e15f8139afbbcbe98b89298674e7980a4a4500dbc54a431e1325a11adfe83f83">app/assets/javascripts/leaflet.share.js</a>
(407)
</li>
<li>
<strong>D</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/4335/files#diff-c4925852e0efd740fa9486b55efb267e4d1f1984fcdcd3125c5d1784b7a0f7a1">app/assets/javascripts/leaflet.sidebar-pane.js</a>
(52)
</li>
<li>
<strong>D</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/4335/files#diff-47fdb48f632a18a6f55b9db0d4e0b134a4019bd2d0380436fc53e3a4ae0e2604">app/assets/javascripts/leaflet.sidebar.js</a>
(55)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/4335/files#diff-e86a39e6d0b163f152db8843fc7d647a3f5d648de4a74f1732bef4474b6e5bc8">app/assets/stylesheets/common.scss</a>
(24)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/4335/files#diff-fa5c6fa3fe725cd20fd8f42d8dc47d0719e073ceeb6947380102831498929f1a">app/assets/stylesheets/print.scss</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/4335/files#diff-c7e7144de4dcf44dbb148d4acc6aa4a9d8581c6a581966a0bbfb598e79730f14">app/controllers/site_controller.rb</a>
(8)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/4335/files#diff-eaeaf6b733bc454c8c41be224e85cdca90bc6e0e5bc1f02f9f86315cfc6fafab">app/views/layouts/map.html.erb</a>
(3)
</li>
<li>
<strong>A</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/4335/files#diff-ef299a7039b85f9fd5ffa1ef3245d38e28bdd71b8746efa50051ec5c6459f16e">app/views/site/layers.html.erb</a>
(34)
</li>
<li>
<strong>A</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/4335/files#diff-df6cc93534769b1229865d70b19383e9a2d29cc7b294041c1eeb81e097ad3714">app/views/site/mapkey.html.erb</a>
(11)
</li>
<li>
<strong>A</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/4335/files#diff-2b34a8a6e260ed3c05d38b8250e07e05617d32985d2250826373e7c2bce40d8f">app/views/site/share.html.erb</a>
(86)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/4335/files#diff-44438ce218f5287c58d0017f965d888715635d94280669896f75841fbd7b4cd7">config/locales/en.yml</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/4335/files#diff-959bc9abc46a55332bb64d5155a79323afa75a50ec1a2137ddd22d926f62c6c5">config/routes.rb</a>
(3)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/4335/files#diff-74c3414af0a76b3935f1a316c51c37b9415ded1fd811d596ba523d38e7c1489b">test/system/index_test.rb</a>
(4)
</li>
</ul>
<h4>Patch Links:</h4>
<ul>
<li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/4335.patch'>https://github.com/openstreetmap/openstreetmap-website/pull/4335.patch</a></li>
<li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/4335.diff'>https://github.com/openstreetmap/openstreetmap-website/pull/4335.diff</a></li>
</ul>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4335">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLPRBURY5MEAA4N5XDTYEBQNJAVCNFSM6AAAAAA7HY3MKOVHI2DSMVQWIX3LMV43ASLTON2WKOZRHE4DSMRVGI3DANY">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLLSMJSQYTH5AMDHWXDYEBQNJA5CNFSM6AAAAAA7HY3MKOWGG33NNVSW45C7OR4XAZNFJFZXG5LFVJRW63LNMVXHIX3JMTHHNEMV74.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/4335</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/4335",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/4335",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>