<p></p>
<p><b>@tomhughes</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4329#discussion_r1392820005">app/controllers/users_controller.rb</a>:</p>
<pre style='color:#555'>> @@ -317,6 +305,24 @@ def auth_failure
 
   private
 
+  def welcome_options
+    uri = URI(session[:referer]) if session[:referer].present?
+    welcome_options = {}
+    welcome_options["oauth_return_url"] = session[:referer] if uri&.path == oauth_authorization_path
</pre>
<p dir="auto">Is there a reason for going back to <code class="notranslate">session[:referer]</code> for the assignment here instead of just using <code class="notranslate">uri</code>?</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4329#discussion_r1392822716">app/controllers/users_controller.rb</a>:</p>
<pre style='color:#555'>> @@ -317,6 +305,24 @@ def auth_failure
 
   private
 
+  def welcome_options
+    uri = URI(session[:referer]) if session[:referer].present?
+    welcome_options = {}
+    welcome_options["oauth_return_url"] = session[:referer] if uri&.path == oauth_authorization_path
+
+    begin
+      %r{map=(.*)/(.*)/(.*)}.match(uri.fragment) do |m|
+        editor = Rack::Utils.parse_query(uri.query).slice("editor")
+        welcome_options = { "zoom" => m[1],
+                            "lat" => m[2],
+                            "lon" => m[3] }.merge(editor).merge(welcome_options)
</pre>
<p dir="auto">Do we need to merge with the existing options here? Does it ever make sense to have both an OAuth return URL and coordinates?</p>
<p dir="auto">Should this whole thing be two separate paths for setting the options based on whether the referer is the oauth return URL or not?</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4329#pullrequestreview-1730077758">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLPWJM2QBME7UWJTH2LYEOHVXAVCNFSM6AAAAAA7BCW6VWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTOMZQGA3TONZVHA">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLNXQB33S5LUFKEA7OTYEOHVXA5CNFSM6AAAAAA7BCW6VWWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTTHD3SD4.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/4329/review/1730077758</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/4329#pullrequestreview-1730077758",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/4329#pullrequestreview-1730077758",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>