<p></p>
<blockquote>
<p dir="auto">What's the purpose of setting the tabindex? Are there any side effects of that in terms of using keyboard navigation?</p>
</blockquote>
<p dir="auto">Without tabindex the action is not "sticky" so the expand is removed again with mouseup and touchend.</p>
<blockquote>
<p dir="auto">In that picture it looks like there is a spurious space between the open parenthesis and the expanded date - if that's true can we get rid of it?</p>
</blockquote>
<p dir="auto">Yes, this is even encoded in the test (from <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="1995484252" data-permission-text="Title is private" data-url="https://github.com/openstreetmap/openstreetmap-website/issues/4349" data-hovercard-type="pull_request" data-hovercard-url="/openstreetmap/openstreetmap-website/pull/4349/hovercard" href="https://github.com/openstreetmap/openstreetmap-website/pull/4349">#4349</a>) if I understand the test:<br>
<code class="notranslate">assert_match %r{^<time title=" *5 March 2014 at 18:58" datetime="2014-03-05T18:58:23Z">.*</time>$}, date</code></p>
<p dir="auto">It comes from <code class="notranslate">l(date, :format => :friendly)</code> where I have no idea which component implements this.<br>
So this is IMO better tackled separately.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4361#issuecomment-1822467149">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLNBDU7PV3MBXNCPWE3YFXFMPAVCNFSM6AAAAAA7V5HPWKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMRSGQ3DOMJUHE">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLO6UORYZWFXQX74BO3YFXFMPA5CNFSM6AAAAAA7V5HPWKWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTTMUCSE2.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/4361/c1822467149</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/4361#issuecomment-1822467149",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/4361#issuecomment-1822467149",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>