<p></p>
<p><b>@grekko</b> commented on this pull request.</p>
<hr>
<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4284#discussion_r1410003986">app/views/application/_settings_menu.html.erb</a>:</p>
<pre style='color:#555'>> @@ -14,5 +14,8 @@
<li class="nav-item">
<%= link_to t(".oauth2_authorizations"), oauth_authorized_applications_path, :class => "nav-link #{'active' if controller_name == 'oauth2_authorized_applications'}" %>
</li>
+ <li class="nav-item">
+ <%= link_to t(".muted_users"), user_mutes_path, :class => "nav-link #{'active' if controller_name == 'user_mutes'}" %>
</pre>
<p dir="auto">yup. I changed <code class="notranslate">messages/outbox.html.erb</code> to also reuse <code class="notranslate">messages/_messages_table.html.erb</code> and therefore pass a custom <code class="notranslate">inner_partial</code> and a new configuration – <code class="notranslate">columns</code> to <code class="notranslate">messages/_messages_table.html.erb</code>.</p>
<p dir="auto">I'd understand if the view logic seems a bit overcomplicated now, but I think its still not too hard to read and therefore the message table logic is kept together in a small set of files.</p>
<p dir="auto">See <a class="commit-link" data-hovercard-type="commit" data-hovercard-url="https://github.com/openstreetmap/openstreetmap-website/commit/c0cbf1c28da68739bc854eb8249f5298ce16e8a5/hovercard" href="https://github.com/openstreetmap/openstreetmap-website/commit/c0cbf1c28da68739bc854eb8249f5298ce16e8a5"><tt>c0cbf1c</tt></a></p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4284#discussion_r1410003986">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLJRIKNHHBWGWYXKXFLYG7EAXAVCNFSM6AAAAAA53SDOR2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTONJWGQYTONBXGY">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLNIH4RST4XETJXX6BDYG7EAXA5CNFSM6AAAAAA53SDOR2WGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTTIWDG4I.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/4284/review/1756417476</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/4284#discussion_r1410003986",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/4284#discussion_r1410003986",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>