<p dir="auto">You have a test that looks like this:</p>
<p dir="auto"><a href="https://github.com/openstreetmap/openstreetmap-website/blob/04c697b468057d1a3604694e7ead9d2c6efd1dfa/test/models/note_test.rb#L40-L42">https://github.com/openstreetmap/openstreetmap-website/blob/04c697b468057d1a3604694e7ead9d2c6efd1dfa/test/models/note_test.rb#L40-L42</a></p>
<p dir="auto">Then Rubocop starts complaining that you don't use <code class="notranslate">assert_predicate</code> and you change the test:</p>
<p dir="auto"><a href="https://github.com/openstreetmap/openstreetmap-website/blob/6892ccd0155b431cc567b4744b1e2759df3e8c68/test/models/note_test.rb#L40-L42">https://github.com/openstreetmap/openstreetmap-website/blob/6892ccd0155b431cc567b4744b1e2759df3e8c68/test/models/note_test.rb#L40-L42</a></p>
<p dir="auto">Yet you keep negative assertions as <code class="notranslate">assert_not</code> and don't change then to <code class="notranslate">assert_not_predicate</code>. Are there any good reasons for that other than Rubocop no complaining?</p>
<div class="highlight highlight-source-ruby" dir="auto"><pre class="notranslate"><span class="pl-en">assert_not_predicate</span> <span class="pl-en">create</span><span class="pl-kos">(</span><span class="pl-pds">:note</span><span class="pl-kos">,</span> <span class="pl-pds">:status</span> <span class="pl-c1">=></span> <span class="pl-s">"hidden"</span><span class="pl-kos">)</span><span class="pl-kos">,</span> <span class="pl-pds">:visible?</span></pre></div>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/openstreetmap/openstreetmap-website/pull/4454'>https://github.com/openstreetmap/openstreetmap-website/pull/4454</a></p>

<h4>Commit Summary</h4>
<ul>
  <li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/4454/commits/3a8a997fb86219e2e11dc76c837d5a237db80019" class="commit-link">3a8a997</a>  Use assert_not_predicate in tests that have assert_predicate</li>
</ul>

<h4 style="display: inline-block">File Changes </h4> <p style="display: inline-block">(<a href="https://github.com/openstreetmap/openstreetmap-website/pull/4454/files">26 files</a>)</p>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4454/files#diff-01e538a73fdc73d111fbb16467deb2763c0da837f141b4b25509dd181d32135a">test/lib/bounding_box_test.rb</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4454/files#diff-05e6fdb66746b5b2da87aa3bb6dc44d1938678d4005aa096460cbe70b1c026dc">test/models/acl_test.rb</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4454/files#diff-62a1c231103d04b9f7a1a13e33ac9cce5aa0a23dba572111e0aa6c9446d2fc3f">test/models/changeset_comment_test.rb</a>
    (12)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4454/files#diff-f71810edf41ac520b7232a82bab9cd0ff5490e215a2bb9a3acd3a7094301ab57">test/models/changeset_tag_test.rb</a>
    (8)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4454/files#diff-1ef888d717e6c2879e02615b3bc9510d966bb3329888eca5ff4d760b7166d460">test/models/client_application_test.rb</a>
    (6)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4454/files#diff-7fbf0e6c10deff5d707995df2d2d9d1eced8fd6d9d23a1fac4818aae7e28bd2f">test/models/issue_test.rb</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4454/files#diff-f6440fd3336b11c0501071041975ac6af9da2d69fbc0a209213bf226a8b4f560">test/models/message_test.rb</a>
    (4)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4454/files#diff-4dce7119318fc3034f2d72ffe84dc5fc634ae6fa13b2dabdf3640131bfc5eb98">test/models/node_tag_test.rb</a>
    (8)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4454/files#diff-e52aeceec5303c34383578ac44daf55f66f0ab282f5d1a39317301325094ae1c">test/models/note_comment_test.rb</a>
    (4)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4454/files#diff-9ed24267e574df2d6b1a08918227fce884dbcaa7cf91e60d0141a3053d620c44">test/models/oauth_token_test.rb</a>
    (6)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4454/files#diff-763bafb88e258710a4e340f4fd1b34fd16dc4c3bc29972a817d591482e6fbd1b">test/models/old_node_tag_test.rb</a>
    (8)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4454/files#diff-622b56f9eecc03fb430a353ff685f96951f19eb229d423a6b10374946df7cfac">test/models/old_relation_tag_test.rb</a>
    (8)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4454/files#diff-869d958577af901fd1209c078ce87ee2407e6cb22910d8825ee07d48b98011ca">test/models/old_way_tag_test.rb</a>
    (8)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4454/files#diff-31ddf8d69d188cc0bc4603fb91fe4ce80e8b9dcfb8594597fa4db3188c0052c1">test/models/redaction_test.rb</a>
    (8)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4454/files#diff-5d4491e91011a9c9e3dac9d9c6089ee084ee1cf5d368d0b0cbc7064ec6825eb5">test/models/relation_member_test.rb</a>
    (4)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4454/files#diff-94144fb56994e0297e799d72d840cabaea97c3e915d53b396f18dc38f4b1a3d6">test/models/relation_tag_test.rb</a>
    (8)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4454/files#diff-8a327ede5b93ff905ead5dc6d960dc90bad6ffefd0dd7cd768921f950f952ac7">test/models/report_test.rb</a>
    (8)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4454/files#diff-3870b3ca8ecd9b6f8a3f35a2944aceddf5c795c100745faed3c62f3c918aed47">test/models/request_token_test.rb</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4454/files#diff-9fd2e1fe5658049094afe3aa0ab829848cd04fd0b3f62d56ad51b1ae40efdc2e">test/models/trace_test.rb</a>
    (22)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4454/files#diff-3434c92a07299ebbd1c5444ae304d70312042ce528181c223d7ee9d48ebf2510">test/models/tracepoint_test.rb</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4454/files#diff-0f73892c02129f3d9cd2a2b5948ebd52c473f67eebfb7ac670071a7fa3320160">test/models/user_preference_test.rb</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4454/files#diff-91bef9fda3c55514e23a4a8edba948f68aad59b57951adcff0b11e9ea9159854">test/models/user_test.rb</a>
    (30)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4454/files#diff-ea4f9e44f635a4483449a074aef7654c9a5d8f58b48907cb2c8c69c5db850980">test/models/way_tag_test.rb</a>
    (8)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4454/files#diff-9f1f22915e6ab6ed93dcabe9188d6288ea0f2e37283bfdff1e9cb79d15bf09b6">test/system/report_diary_entry_test.rb</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4454/files#diff-af1d9ba5f81fb705a9dd9e1483a8f94dae9996614dc1c24a509c586f78d211e7">test/validators/characters_validator_test.rb</a>
    (4)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4454/files#diff-3501151621ce71d40be3159d8ebd8616afcf1b8e9be3669077f3a728a4f587bf">test/validators/whitespace_validator_test.rb</a>
    (4)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/4454.patch'>https://github.com/openstreetmap/openstreetmap-website/pull/4454.patch</a></li>
  <li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/4454.diff'>https://github.com/openstreetmap/openstreetmap-website/pull/4454.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4454">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLM5Q2ECKBHFV5UYRU3YMVKLLAVCNFSM6AAAAABBLNGIS2VHI2DSMVQWIX3LMV43ASLTON2WKOZSGA3DIMBRGY4TCNQ">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLKILV4SRXZ2X5JBCODYMVKLLA5CNFSM6AAAAABBLNGIS2WGG33NNVSW45C7OR4XAZNFJFZXG5LFVJRW63LNMVXHIX3JMTHHWBTGCQ.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/4454</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/4454",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/4454",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>