<p></p>
<p><b>@tomhughes</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4436#discussion_r1443975516">test/system/oauth2_test.rb</a>:</p>
<pre style='color:#555'>>      visit oauth_authorized_applications_path
 
+    accept_alert do
+      click_link "Revoke Access"
+    end
</pre>
<p dir="auto">Rather than adding this (and the comment above) all of which took me a few minutes to understand, wouldn't it be simpler just to change the assert below to expect an application?</p>
<p dir="auto">This test is just trying to check that the authorized applications page exists and displays rather than the specific contents...</p>
<p dir="auto">An alternative which would be clearer would be to drop the comment and add an assertion above the revoke to check that the website application is listed and then revoke it and check you get the no apps message?</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4436#pullrequestreview-1807777642">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLMN5N3SXHHMPFRGBFLYNJYQFAVCNFSM6AAAAABBCO3J5WVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTQMBXG43TONRUGI">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLPRDLW2BQ3S3XICUB3YNJYQFA5CNFSM6AAAAABBCO3J5WWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTTLYB7WU.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/4436/review/1807777642</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/4436#pullrequestreview-1807777642",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/4436#pullrequestreview-1807777642",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>