<ul dir="auto">
<li>convert changeset comment related tests to system tests because <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="1959849322" data-permission-text="Title is private" data-url="https://github.com/openstreetmap/openstreetmap-website/issues/4313" data-hovercard-type="pull_request" data-hovercard-url="/openstreetmap/openstreetmap-website/pull/4313/hovercard?comment_id=1395452804&comment_type=review_comment" href="https://github.com/openstreetmap/openstreetmap-website/pull/4313#discussion_r1395452804">#4313 (comment)</a> and similar tests for notes are also system tests</li>
<li>shorten changeset page view code, remove unnecessary attributes (<code class="notranslate">class="notice"</code>, <code class="notranslate">class="action-button</code>, <code class="notranslate">data-changeset-id</code>)</li>
<li>convert comment hide/unhide <code class="notranslate"><span></code>s to buttons, now they can get keyboard focus</li>
<li>display error message when subscribe fails, similar to <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2069193786" data-permission-text="Title is private" data-url="https://github.com/openstreetmap/openstreetmap-website/issues/4462" data-hovercard-type="pull_request" data-hovercard-url="/openstreetmap/openstreetmap-website/pull/4462/hovercard" href="https://github.com/openstreetmap/openstreetmap-website/pull/4462">#4462</a></li>
</ul>
<hr>
<h4>You can view, comment on, or merge this pull request online at:</h4>
<p> <a href='https://github.com/openstreetmap/openstreetmap-website/pull/4463'>https://github.com/openstreetmap/openstreetmap-website/pull/4463</a></p>
<h4>Commit Summary</h4>
<ul>
<li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/4463/commits/394637acf1409f7c037a72cb8d545ad281bfc8c3" class="commit-link">394637a</a> Test notices of disabled changeset commenting</li>
<li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/4463/commits/f4309fabc0e0f2db955b048c9b366a0e22b23382" class="commit-link">f4309fa</a> Test changeset commenting</li>
<li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/4463/commits/b5433facb8a791059b5ef7d5eeb9055ebb76012e" class="commit-link">b5433fa</a> Turn hide/unhide comment controls into buttons</li>
<li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/4463/commits/dc907414c932b5423e5b84aa40304e9f880b9a79" class="commit-link">dc90741</a> Remove hidden comments test from controller tests</li>
<li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/4463/commits/10a22b77e3f67c19a3451b41506e47afc7d38aa3" class="commit-link">10a22b7</a> Simplify moderator check when showing changeset comments</li>
<li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/4463/commits/16dee0a42c82ef6b7a5884150b341b83539ba4dc" class="commit-link">16dee0a</a> Remove duplicated code from changeset comments list</li>
<li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/4463/commits/fb06553511f21be31b926ec81b00338e6795cdbd" class="commit-link">fb06553</a> Show api error message if failed to (un)subscribe</li>
<li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/4463/commits/7d2abb63665c3da9fcccfab7571d71fec9078a90" class="commit-link">7d2abb6</a> Scroll to api error message</li>
</ul>
<h4 style="display: inline-block">File Changes </h4> <p style="display: inline-block">(<a href="https://github.com/openstreetmap/openstreetmap-website/pull/4463/files">7 files</a>)</p>
<ul>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/4463/files#diff-e8b0bd562b0aaead17e44d572d51fcc72fa846c7b54ae5df2dc6434fb80834dc">app/assets/javascripts/index/changeset.js</a>
(27)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/4463/files#diff-e86a39e6d0b163f152db8843fc7d647a3f5d648de4a74f1732bef4474b6e5bc8">app/assets/stylesheets/common.scss</a>
(5)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/4463/files#diff-fba7159a4abd78f8b24f765a0c58ebe47a24be99e185c373175f20f612a5d781">app/views/browse/changeset.html.erb</a>
(65)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/4463/files#diff-01df9fbcb9fb4907831d5bf348fc535f13caf85ed834db5f3f039c2407bf97bf">test/controllers/browse_controller_test.rb</a>
(14)
</li>
<li>
<strong>D</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/4463/files#diff-61df78335fb0a8542698c24b6fb46b1f5e144e6c207382c2713abb64f97b05f8">test/integration/user_changeset_comments_test.rb</a>
(55)
</li>
<li>
<strong>A</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/4463/files#diff-19bcde6cc9485473c9542636cee0cf664834e8a9409ddf6aad3893cc0847e0b4">test/system/changeset_comments_test.rb</a>
(130)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/4463/files#diff-ba37813ca277c227a74a372479b7b05b7f3ff085d890ab708f80d62573efdb7a">test/test_helper.rb</a>
(5)
</li>
</ul>
<h4>Patch Links:</h4>
<ul>
<li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/4463.patch'>https://github.com/openstreetmap/openstreetmap-website/pull/4463.patch</a></li>
<li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/4463.diff'>https://github.com/openstreetmap/openstreetmap-website/pull/4463.diff</a></li>
</ul>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4463">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLKMMK635DLTVUUXYMLYNQFOJAVCNFSM6AAAAABBRUCPACVHI2DSMVQWIX3LMV43ASLTON2WKOZSGA3TANRXG42DSMA">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLMIAAI5PCGHTXAIYK3YNQFOJA5CNFSM6AAAAABBRUCPACWGG33NNVSW45C7OR4XAZNFJFZXG5LFVJRW63LNMVXHIX3JMTHHW3AH6I.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/4463</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/4463",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/4463",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>