<p></p>
<p><b>@milan-cvetkovic</b> commented on this pull request.</p>
<hr>
<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4455#discussion_r1444542704">app/views/users/new.html.erb</a>:</p>
<pre style='color:#555'>> @@ -42,11 +42,32 @@
<%= f.password_field :pass_crypt, :tabindex => 6 %>
<%= f.password_field :pass_crypt_confirmation, :tabindex => 7 %>
+ <p class="mb-3 text-muted"><%= t(".by_signing_up_html",
+ :tou_link => link_to(t("layouts.tou"),
+ "https://wiki.osmfoundation.org/wiki/Terms_of_Use",
+ :target => :new),
+ :contributor_terms_link => link_to(t(".contributor_terms"),
+ t(".contributor_terms_url"),
</pre>
<blockquote>
<p dir="auto">Did you make it translatable so the French and Italian versions could be linked to directly for those languages?</p>
</blockquote>
<p dir="auto">This was the idea, similar to how <a href="https://github.com/openstreetmap/openstreetmap-website/blob/948c1cdfb76ccb6c770ec2bed7001f966d3c5570/app/views/accounts/edit.html.erb#L46C9-L46C113">what's this</a> link next to "Contributor Terms" label in accounts/edit pages is resolved.</p>
<hr>
<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4455#discussion_r1444584146">test/system/user_signup_test.rb</a>:</p>
<pre style='color:#555'>> @@ -1,29 +0,0 @@
-require "application_system_test_case"
-
-class UserSignupTest < ApplicationSystemTestCase
- test "Sign up from login page" do
</pre>
<p dir="auto">good point, will bring it back</p>
<hr>
<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4455#discussion_r1444598781">app/views/users/new.html.erb</a>:</p>
<pre style='color:#555'>> <h4><%= t ".about.header" %></h4>
<p><%= t ".about.paragraph_1" %></p>
- <p><%= t ".about.paragraph_2" %></p>
</pre>
<p dir="auto">Makes sense - I blindly followed the figma design. Will modify the second paragraph to remove bit about sending the email.</p>
<hr>
<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4455#discussion_r1444609568">app/controllers/users_controller.rb</a>:</p>
<pre style='color:#555'>> # Something is wrong with a new user, so rerender the form
- render :action => "new"
- elsif current_user.auth_provider.present?
+ render :action => "new_association"
+ else
# Verify external authenticator before moving on
session[:new_user] = current_user.attributes.slice("email", "display_name", "pass_crypt", "consider_pd")
redirect_to auth_url(current_user.auth_provider, current_user.auth_uid), :status => :temporary_redirect
</pre>
<p dir="auto">I was about to ask the same question. Thanks for clarifying what the purpose of the additional round-trip to the provider was about.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4455#discussion_r1444542704">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLNAUUEFBJ6ZGT2QBALYNUWWFAVCNFSM6AAAAABBLOL2OWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTQMBYHE4DKOBZGE">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLOSMPLOG2KMJL44KZDYNUWWFA5CNFSM6AAAAABBLOL2OWWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTTL2LXSG.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/4455/review/1808985891</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/4455#discussion_r1444542704",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/4455#discussion_r1444542704",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>