<p></p>
<p dir="auto">So <a class="commit-link" data-hovercard-type="commit" data-hovercard-url="https://github.com/openstreetmap/openstreetmap-website/commit/b1553135fc03e6b4b5f919b98d0fe0e25f37ae10/hovercard" href="https://github.com/openstreetmap/openstreetmap-website/commit/b1553135fc03e6b4b5f919b98d0fe0e25f37ae10"><tt>b155313</tt></a> was the original fix - to preserve the second copy in the hash so that the <code class="notranslate">before_save</code> filter could work.</p>
<p dir="auto">Apparently I then fairly quickly decided to try that alternative approach but I'm not sure if that was because the first one didn't work or I just thought it was better to hash earlier.</p>
<p dir="auto">The original problem was that the change to storing attributes instead of user records in the sessions in <a class="commit-link" data-hovercard-type="commit" data-hovercard-url="https://github.com/openstreetmap/openstreetmap-website/commit/898a3882c58ed4a1a7e01682052b2078cae7ffd8/hovercard" href="https://github.com/openstreetmap/openstreetmap-website/commit/898a3882c58ed4a1a7e01682052b2078cae7ffd8"><tt>898a388</tt></a> had broken password recording for new users because only one copy made it to the filter.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/issues/4474#issuecomment-1889522628">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLJVGCKJYICGWWNFMA3YOFJ73AVCNFSM6AAAAABBYA4LM2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOBZGUZDENRSHA">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLLTT56PIGMFL6LJ4CLYOFJ73A5CNFSM6AAAAABBYA4LM2WGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTTQT7J4I.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/issues/4474/1889522628</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/issues/4474#issuecomment-1889522628",
"url": "https://github.com/openstreetmap/openstreetmap-website/issues/4474#issuecomment-1889522628",
"name": "View Issue"
},
"description": "View this Issue on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>