<p></p>
<blockquote>
<p dir="auto"><a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/grekko/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/grekko">@grekko</a> in this pull request chose to reveal the opening comment, both in the web ui and in the api</p>
</blockquote>
<p dir="auto">That is true. The code changes in this PR effectively work around the special handling introduced in <a class="commit-link" data-hovercard-type="commit" data-hovercard-url="https://github.com/openstreetmap/openstreetmap-website/commit/6027c42ee7b5ac6b36e8a62135d2cf67b3ca8250/hovercard" href="https://github.com/openstreetmap/openstreetmap-website/commit/6027c42ee7b5ac6b36e8a62135d2cf67b3ca8250"><tt>6027c42</tt></a>, keeping the Note body of then-deleted users accessible. Thanks for pointing this out.</p>
<p dir="auto">Just to be explicit: No User-related information would NOT be accessible. The author would be displayed as <code class="notranslate">anonymous</code>. Also note comments of deleted Users would continue NOT to be accessible.</p>
<p dir="auto">AFAIU the current policy of <code class="notranslate">User#soft_destroy</code> we would need to keep the information of Note-records by deleted Users hidden. Here a screenshot:</p>
<a href="https://github.com/openstreetmap/openstreetmap-website/assets/28648/fda8ccf1-3a1f-41ee-87ea-fd93aa97355c">SCR-20240116-qskd.png (view on web)</a>
<p dir="auto">At this point I think it is useful to clarify if there are good reasons not to continue to comply with the aforementioned policy. If there are none, I can think of the following changes to move forward:</p>
<ul dir="auto">
<li>Notes of deleted users are not hidden per se, but the associated information (body and author) is redacted – effectively hiding the Notes comment. The author is already redacted.</li>
<li>Associated comments to the Note continue to be accessible (unless their authors are also deleted).</li>
</ul>
<p dir="auto">Or alternatively:</p>
<ul dir="auto">
<li>The Note and all of its associated comments are hidden once the original author of the Note is deleted.</li>
</ul>
<p dir="auto">Although the latter approach seems rather invasive to other users. I can imagine that Note comments carry a lot of value even though if the message of the initial Note is redacted. Also it seems wrong that a User can effectively manipulate the visibility of other Users comments.</p>
<p dir="auto"><a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/AntonKhorev/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/AntonKhorev">@AntonKhorev</a> Do you think I'm missing here something else?</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4481#issuecomment-1894745472">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLINJC2YQOGTXDKWDYLYO4MXBAVCNFSM6AAAAABB4FLGOWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOJUG42DKNBXGI">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLL5JKIVOUT5TBQ42T3YO4MXBA5CNFSM6AAAAABB4FLGOWWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTTQ56CYA.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/4481/c1894745472</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/4481#issuecomment-1894745472",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/4481#issuecomment-1894745472",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>