<p></p>
<p><b>@tomhughes</b> requested changes on this pull request.</p>
<hr>
<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4462#discussion_r1453864078">app/assets/javascripts/index/note.js</a>:</p>
<pre style='color:#555'>> @@ -52,20 +52,17 @@ OSM.Note = function (map) {
OSM.loadSidebarContent(path, function () {
initialize(path, id, moveToNote);
});
+ },
+ error: function (xhr) {
+ $(form).find("#comment-error").text(xhr.responseText);
+ $(form).find("#comment-error").prop("hidden", false);
</pre>
<p dir="auto">I think these calls can be chained rather than doing the <code class="notranslate">find</code> twice?</p>
<p dir="auto">Also should the <code class="notranslate">success</code> callback hide the error again, in case the user reads the message in a different tab than comes back and submits again?</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4462#pullrequestreview-1824637832">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLIWJ5IO6VEPNBBAOCDYO3EB5AVCNFSM6AAAAABBQNYTACVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTQMRUGYZTOOBTGI">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLNFVCIAGITN6CK7BKTYO3EB5A5CNFSM6AAAAABBQNYTACWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTTMYHBYQ.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/4462/review/1824637832</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/4462#pullrequestreview-1824637832",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/4462#pullrequestreview-1824637832",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>