<p></p>
<p><b>@AntonKhorev</b> commented on this pull request.</p>
<hr>
<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4462#discussion_r1454191330">app/assets/javascripts/index/note.js</a>:</p>
<pre style='color:#555'>> @@ -52,20 +52,17 @@ OSM.Note = function (map) {
OSM.loadSidebarContent(path, function () {
initialize(path, id, moveToNote);
});
+ },
+ error: function (xhr) {
+ $(form).find("#comment-error").text(xhr.responseText);
+ $(form).find("#comment-error").prop("hidden", false);
</pre>
<blockquote>
<p dir="auto">Also should the success callback hide the error again</p>
</blockquote>
<p dir="auto">It doesn't have to because it rewrites the entire sidebar contents.</p>
<p dir="auto">Added test to check that:<br>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/4462/files#diff-960e6e9200fa7ea5eed049f5de24d807cf7c7a4c0434875d23139ff261ddc0feR73-R79">https://github.com/openstreetmap/openstreetmap-website/pull/4462/files#diff-960e6e9200fa7ea5eed049f5de24d807cf7c7a4c0434875d23139ff261ddc0feR73-R79</a></p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4462#discussion_r1454191330">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLNSVRT6FUC3ZGMAPWDYO4DG7AVCNFSM6AAAAABBQNYTACVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTQMRVGY3DINBWGE">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLLCZHOG4MSAURR47E3YO4DG7A5CNFSM6AAAAABBQNYTACWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTTM2FW42.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/4462/review/1825664461</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/4462#discussion_r1454191330",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/4462#discussion_r1454191330",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>