<p></p>
<blockquote>
<p dir="auto">I guess maybe we should just disable them fully - probably the idea of the auto-generated todo putting a numeric limit in instead was to stop people making them worse but obviously we don't do that.</p>
</blockquote>
<p dir="auto">Well maybe in future I should refuse any PRs that increase the number! But I think other people would be unhappy with that approach.</p>
<p dir="auto">I don't want to turn it off, since it's making a point that needs to be made. <code class="notranslate">user.rb</code> is far too big to understand at a glance, and imho should be refactored, but like you say that's a longer-term TODO and I can't block a security fix by waiting for the refactoring.</p>
<p dir="auto">I suspect what we should do is make it a per-file exemption rather than a global one, so that when we refactor <code class="notranslate">user.rb</code> we don't find that there are many other files that have grown in the meantime.</p>
<blockquote>
<p dir="auto">Previously pull requests were merged with a separate commit changing rubocop config: <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="1937126055" data-permission-text="Title is private" data-url="https://github.com/openstreetmap/openstreetmap-website/issues/4284" data-hovercard-type="pull_request" data-hovercard-url="/openstreetmap/openstreetmap-website/pull/4284/hovercard" href="https://github.com/openstreetmap/openstreetmap-website/pull/4284">#4284</a> <a href="https://github.com/openstreetmap/openstreetmap-website/commit/393914d35b970e98c825dc650f679fcb12b6655e">393914d</a>.</p>
</blockquote>
<p dir="auto">🤷 So I'm inconsistent, perhaps? But in general I like to make sure that tests pass for all commits, so that <code class="notranslate">git bisect</code> works smoothly. And it was easy for me to fix while I was making commits on this PR anyway. But perfect is the enemy of good so it's not a super strict rule or anything.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4218#issuecomment-1898673879">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLJKCDFT33Q6HL3B3OTYPE4B5AVCNFSM6AAAAAA4IR4N2CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOJYGY3TGOBXHE">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLN2APOMZTYKIFEHNGLYPE4B5A5CNFSM6AAAAAA4IR4N2CWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTTRFN3NO.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/4218/c1898673879</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/4218#issuecomment-1898673879",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/4218#issuecomment-1898673879",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>