<p></p>
<p dir="auto"><a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/AntonKhorev/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/AntonKhorev">@AntonKhorev</a> thank you for the PR, that's a good catch. Without it, there's a risk of soft deletes failing.</p>
<p dir="auto">I changed the code slightly - merging your two commits as <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/pnorman/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/pnorman">@pnorman</a> suggested, and also refactoring slightly to move the change detection to the <code class="notranslate">validate</code> statement, to align it with the other validations. I wanted to check that this actually worked (the documentation wasn't 100% clear to me) and by the time I'd checked I figured it was easier for me to commit the code than to ask you to just do the same work!</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4218#issuecomment-1898241063">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLLHHRSD3MAVELH2ZHLYPD45BAVCNFSM6AAAAAA4IR4N2CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOJYGI2DCMBWGM">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLJWIPQJAD3MOS3IOZLYPD45BA5CNFSM6AAAAAA4IR4N2CWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTTRETOCO.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/4218/c1898241063</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/4218#issuecomment-1898241063",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/4218#issuecomment-1898241063",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>