<p></p>
<p><b>@tomhughes</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4480#discussion_r1460931241">app/assets/javascripts/index.js</a>:</p>
<pre style='color:#555'>> @@ -355,6 +355,17 @@ $(document).ready(function () {
     return page;
   };
 
+  OSM.OldBrowse = function () {
+    var page = {};
+
+    page.pushstate = page.popstate = function (path) {
+      OSM.loadSidebarContent(path, function () {
</pre>
<p dir="auto">You can just drop the second argument here as <code class="notranslate">loadSidebarContent</code> will only try and call the callback if one is passed.</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4480#discussion_r1460931844">app/assets/javascripts/index.js</a>:</p>
<pre style='color:#555'>> @@ -369,8 +380,11 @@ $(document).ready(function () {
     "/user/:display_name/history": history,
     "/note/:id": OSM.Note(map),
     "/node/:id(/history)": OSM.Browse(map, "node"),
+    "/node/:id/history/:version": OSM.OldBrowse(map, "node"),
</pre>
<p dir="auto">As <code class="notranslate">oldBrowse</code> doesn't take any arguments there's no need to pass anything here, or to the other two calls.</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4480#discussion_r1460942425">app/controllers/old_nodes_controller.rb</a>:</p>
<pre style='color:#555'>> @@ -0,0 +1,19 @@
+class OldNodesController < ApplicationController
+  layout :map_layout
+
+  before_action :authorize_web
+  before_action :set_locale
+  before_action -> { check_database_readable(:need_api => true) }
+  before_action :require_oauth
+
+  authorize_resource
+
+  around_action :web_timeout
+
+  def show
+    @type = "node"
+    @feature = OldNode.preload(:old_tags, :changeset => [:changeset_tags, :user]).find([params[:id], params[:version]])
</pre>
<p dir="auto">In the <code class="notranslate">browse#node</code> action for the current view we preload the containing relations here - is that not possible for the historical objects? We still seem to be rendering them?</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4480#pullrequestreview-1835360339">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLO6JX6NZ6YT52QWHBLYPUYCJAVCNFSM6AAAAABB4B3G3WVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTQMZVGM3DAMZTHE">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLNVHHNE5TTPQ2NHNSDYPUYCJA5CNFSM6AAAAABB4B3G3WWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTTNMVQFG.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/4480/review/1835360339</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/4480#pullrequestreview-1835360339",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/4480#pullrequestreview-1835360339",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>