<p></p>
<p><b>@gravitystorm</b> requested changes on this pull request.</p>

<p dir="auto">Hi <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/birante/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/birante">@birante</a> , thank you for this pull request.</p>
<p dir="auto">First, I think there is a misunderstanding about the problem described in <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2104513661" data-permission-text="Title is private" data-url="https://github.com/openstreetmap/openstreetmap-website/issues/4501" data-hovercard-type="pull_request" data-hovercard-url="/openstreetmap/openstreetmap-website/pull/4501/hovercard" href="https://github.com/openstreetmap/openstreetmap-website/pull/4501">#4501</a>. The issue described is for the login page (not the signup page), and it is for the situation where someone accidentally includes leading/trailing whitespace when trying to sign in.</p>
<p dir="auto">Secondly, a PR to fix this issue will need tests, to prove that it works, and to prevent any future breakage if we ever refactor the code.</p>
<p dir="auto">Finally, I would be interested to see if there is a rubygem that is already written to tackle this problem, so that we can easily apply the same solution to other forms on the website. For example, we could use something like <a href="https://github.com/holli/auto_strip_attributes">https://github.com/holli/auto_strip_attributes</a></p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/4501#pullrequestreview-1853941345">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLIP4MHKST52DWBP77TYRJLIHAVCNFSM6AAAAABCOVOVRGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTQNJTHE2DCMZUGU">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLP5YDS3IHUM5VS53B3YRJLIHA5CNFSM6AAAAABCOVOVRGWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTTOQDTGC.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/4501/review/1853941345</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/4501#pullrequestreview-1853941345",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/4501#pullrequestreview-1853941345",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>